Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1520123002: Fix state restoration logic in canvas 2d wakeup from hibernation (Closed)

Created:
5 years ago by Justin Novosad
Modified:
5 years ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis, xlai (Olivia), xidachen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix state restoration logic in canvas 2d wakeup from hibernation This fixes an important detail that was overlooked in https://codereview.chromium.org/1507863005/: After a Canvas2DLayerBridge wakes up from hibernation, if deferred rendering is disabled, the matrix+clip stack must be reconstructed on the new SkCanas. Same thing when a hibernating canvas switches to software rendering mode for rendering in the background. BUG=567161 Committed: https://crrev.com/4a48eda91633abbc68d9ed7a3dbce946840fee0a Cr-Commit-Position: refs/heads/master@{#365093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 4 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 5 chunks +130 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Justin Novosad
PTAL
5 years ago (2015-12-14 02:45:16 UTC) #2
Stephen White
LGTM
5 years ago (2015-12-14 18:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520123002/1
5 years ago (2015-12-14 20:39:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 20:52:41 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-14 20:53:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a48eda91633abbc68d9ed7a3dbce946840fee0a
Cr-Commit-Position: refs/heads/master@{#365093}

Powered by Google App Engine
This is Rietveld 408576698