Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1507863005: [2D Canvas] Send GPU resources into hibernation when page is not visible (Closed)

Created:
5 years ago by Justin Novosad
Modified:
5 years ago
Reviewers:
Stephen White, rkaplow
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis, xlai (Olivia), xidachen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[2D Canvas] Send GPU resources into hibernation when page is not visible This change adds the notion of a hibernation state to Canvas2DLayerBridge. The idea is to read back GPU buffers into RAM in order to free-up GPU memory for foreground tasks. The switch to hibernation happens in a idle task, to avoid interfering with tab switching and navigation event performance. BUG=567161 Committed: https://crrev.com/8b5cfe1703c16019566f00190dfd8c972af25c11 Cr-Commit-Position: refs/heads/master@{#364705}

Patch Set 1 #

Patch Set 2 : iter 2 #

Patch Set 3 : tests + histogram #

Total comments: 3

Patch Set 4 : nits #

Patch Set 5 : resolved merge #

Patch Set 6 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 2 3 4 4 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 3 4 15 chunks +147 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 2 3 4 5 4 chunks +450 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
Justin Novosad
PTAL
5 years ago (2015-12-09 21:57:29 UTC) #2
Justin Novosad
+rkaplow for histograms owner
5 years ago (2015-12-09 21:58:21 UTC) #4
Stephen White
LGTM w/nits https://codereview.chromium.org/1507863005/diff/40001/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp (right): https://codereview.chromium.org/1507863005/diff/40001/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp#newcode232 third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:232: // exactly one faillure or exit event. ...
5 years ago (2015-12-10 16:13:10 UTC) #5
rkaplow
lgtm histograms lgtm
5 years ago (2015-12-10 20:56:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507863005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507863005/60001
5 years ago (2015-12-10 22:12:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/91605) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-10 22:18:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507863005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507863005/80001
5 years ago (2015-12-11 04:26:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/154618) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years ago (2015-12-11 05:27:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507863005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507863005/100001
5 years ago (2015-12-11 13:39:41 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-11 15:23:30 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-11 15:24:20 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8b5cfe1703c16019566f00190dfd8c972af25c11
Cr-Commit-Position: refs/heads/master@{#364705}

Powered by Google App Engine
This is Rietveld 408576698