Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1519723002: Revert of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (Closed)

Created:
5 years ago by Ryan Hamilton
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Revert of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1507853003/ ) Reason for revert: Reverting all QUIC m47 patches. Original issue's description: > Reland of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1506043002/ ) > > Reason for revert: > Broke the build > > > Original issue's description: > > Revert of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1507923003/ ) > > > > Reason for revert: > > Broke build > > > > Original issue's description: > > > Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data. > > > > > > Merge internal change: 109493807 > > > > > > BUG=109446528 > > > > > > Review URL: https://codereview.chromium.org/1505563002 > > > > > > Cr-Commit-Position: refs/heads/master@{#363395} > > > (cherry picked from commit 2945a59ad069da6a755af021dd07b33c29d11574) > > > > > > Committed: https://chromium.googlesource.com/chromium/src/+/b8d8c97b431530245d8c1f67c323926d6099ee64 > > > > TBR= > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=109446528 > > TBR= > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=109446528 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=109446528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M net/quic/quic_connection.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Ryan Hamilton
5 years ago (2015-12-10 23:55:05 UTC) #1
Created Revert of Close the QUIC connection when non-crypto stream data is
written at ENCRYPTION_NONE. Flag protected…

Powered by Google App Engine
This is Rietveld 408576698