Issue 1507853003: Reland of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected…

Issue 1507853003: Reland of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (Closed)

Created:
5 years ago by Ryan Hamilton

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2526

Target Ref:
refs/pending/branch-heads/2526

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1506043002/ ) Reason for revert: Broke the build Original issue's description: > Revert of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1507923003/ ) > > Reason for revert: > Broke build > > Original issue's description: > > Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data. > > > > Merge internal change: 109493807 > > > > BUG=109446528 > > > > Review URL: https://codereview.chromium.org/1505563002 > > > > Cr-Commit-Position: refs/heads/master@{#363395} > > (cherry picked from commit 2945a59ad069da6a755af021dd07b33c29d11574) > > > > Committed: https://chromium.googlesource.com/chromium/src/+/b8d8c97b431530245d8c1f67c323926d6099ee64 > > TBR= > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=109446528 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=109446528

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -0 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/mock_crypto_client_stream.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

Created Reland of Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. ...

5 years ago (2015-12-08 03:00:31 UTC) #1

commit-bot: I haz the power

Description was changed from ========== Reland of Close the QUIC connection when non-crypto stream data ...

5 years ago (2015-12-08 03:06:35 UTC) #2

Message was sent while issue was closed.

Description was changed from

==========
Reland of Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of
https://codereview.chromium.org/1506043002/ )

Reason for revert:
Broke the build


Original issue's description:
> Revert of Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of
https://codereview.chromium.org/1507923003/ )
> 
> Reason for revert:
> Broke build
> 
> Original issue's description:
> > Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected by
gfe2_reloadable_flag_quic_never_write_unencrypted_data.
> > 
> > Merge internal change: 109493807
> > 
> > BUG=109446528
> > 
> > Review URL: https://codereview.chromium.org/1505563002
> > 
> > Cr-Commit-Position: refs/heads/master@{#363395}
> > (cherry picked from commit 2945a59ad069da6a755af021dd07b33c29d11574)
> > 
> > Committed:
https://chromium.googlesource.com/chromium/src/+/b8d8c97b431530245d8c1f67c323...
> 
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=109446528

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=109446528
==========

to

==========
Reland of Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of
https://codereview.chromium.org/1506043002/ )

Reason for revert:
Broke the build


Original issue's description:
> Revert of Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of
https://codereview.chromium.org/1507923003/ )
> 
> Reason for revert:
> Broke build
> 
> Original issue's description:
> > Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE. Flag protected by
gfe2_reloadable_flag_quic_never_write_unencrypted_data.
> > 
> > Merge internal change: 109493807
> > 
> > BUG=109446528
> > 
> > Review URL: https://codereview.chromium.org/1505563002
> > 
> > Cr-Commit-Position: refs/heads/master@{#363395}
> > (cherry picked from commit 2945a59ad069da6a755af021dd07b33c29d11574)
> > 
> > Committed:
https://chromium.googlesource.com/chromium/src/+/b8d8c97b431530245d8c1f67c323...
> 
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=109446528

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=109446528
==========

Ryan Hamilton

5 years ago (2015-12-10 23:55:05 UTC) #3

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1519723002/ by rch@chromium.org.

The reason for reverting is: Reverting all QUIC m47 patches..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages