Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE.

Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE.
Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data.

Merge internal change: 109493807

BUG=566156
Committed: https://crrev.com/2945a59ad069da6a755af021dd07b33c29d11574
Cr-Commit-Position: refs/heads/master@{#363395}

[Ryan Hamilton, 2015-12-05 16:31:08]

rch@chromium.org changed reviewers:
+ ianswett@google.com, rtenneti@chromium.org

[ramant (doing other things), 2015-12-05 17:02:12]

lgtm

[Ryan Hamilton, 2015-12-05 19:35:38]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-05 19:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/40001

[commit-bot: I haz the power, 2015-12-05 20:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 20:27:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ianswett, 2015-12-05 21:39:04]

ianswett@chromium.org changed reviewers:
+ ianswett@chromium.org

[ianswett, 2015-12-05 21:39:04]

The CQ bit was checked by ianswett@chromium.org

[ianswett, 2015-12-05 21:39:05]

lgtm

[commit-bot: I haz the power, 2015-12-05 21:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/40001

[commit-bot: I haz the power, 2015-12-05 22:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 22:44:22]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-12-05 23:41:38]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-05 23:42:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/40001

[commit-bot: I haz the power, 2015-12-06 01:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 01:40:02]

Exceeded global retry quota

[Ryan Hamilton, 2015-12-06 03:52:36]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-06 03:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/40001

[commit-bot: I haz the power, 2015-12-06 04:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 04:29:49]

Failed to apply patch for net/quic/quic_flags.cc:
While running git apply --index -3 -p1;
  error: patch failed: net/quic/quic_flags.cc:118
  Falling back to three-way merge...
  Applied patch to 'net/quic/quic_flags.cc' with conflicts.
  U net/quic/quic_flags.cc

Patch:       net/quic/quic_flags.cc
Index: net/quic/quic_flags.cc
diff --git a/net/quic/quic_flags.cc b/net/quic/quic_flags.cc
index
b63a0e525788a73e1e9eccf8178e8d30218bd426..19690fc4487d43c81d9c02d7bc53ed1dc8cca83c
100644
--- a/net/quic/quic_flags.cc
+++ b/net/quic/quic_flags.cc
@@ -118,3 +118,6 @@ bool FLAGS_quic_track_single_retransmission = true;
 // If true, allow each quic stream to write 16k blocks rather than doing a
round
 // robin of one packet per session when ack clocked or paced.
 bool FLAGS_quic_batch_writes = true;
+
+// If true, Close the connection instead of writing unencrypted stream data.
+bool FLAGS_quic_never_write_unencrypted_data = true;

[commit-bot: I haz the power, 2015-12-06 04:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[Ryan Hamilton, 2015-12-06 05:07:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-12-06 05:07:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
ianswett@chromium.org, rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1505563002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-06 05:07:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/60001

[commit-bot: I haz the power, 2015-12-06 06:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 06:12:42]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-12-06 17:54:19]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-06 17:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/60001

[commit-bot: I haz the power, 2015-12-06 18:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 18:52:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-12-06 19:06:54]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-06 19:07:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/60001

[commit-bot: I haz the power, 2015-12-06 20:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 20:34:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-12-06 23:25:22]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-06 23:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/60001

[commit-bot: I haz the power, 2015-12-07 00:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 00:36:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-12-07 03:03:43]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2015-12-07 03:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505563002/60001

[commit-bot: I haz the power, 2015-12-07 03:37:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-07 03:38:15]

Description was changed from

==========
Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE.
Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data.

Merge internal change: 109493807

BUG=109446528
==========

to

==========
Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE.
Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data.

Merge internal change: 109493807

BUG=109446528

Committed: https://crrev.com/2945a59ad069da6a755af021dd07b33c29d11574
Cr-Commit-Position: refs/heads/master@{#363395}
==========

[commit-bot: I haz the power, 2015-12-07 03:38:16]

Patchset 4 (id:??) landed as
https://crrev.com/2945a59ad069da6a755af021dd07b33c29d11574
Cr-Commit-Position: refs/heads/master@{#363395}

[Ryan Hamilton, 2015-12-07 03:38:51]

Description was changed from

==========
Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE.
Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data.

Merge internal change: 109493807

BUG=109446528

Committed: https://crrev.com/2945a59ad069da6a755af021dd07b33c29d11574
Cr-Commit-Position: refs/heads/master@{#363395}
==========

to

==========
Close the QUIC connection when non-crypto stream data is written at
ENCRYPTION_NONE.
Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data.

Merge internal change: 109493807

BUG=566156

Committed: https://crrev.com/2945a59ad069da6a755af021dd07b33c29d11574
Cr-Commit-Position: refs/heads/master@{#363395}
==========