Prevent overflow in length() in GLCircularRRectEffect

Prevent overflow in length() in GLCircularRRectEffect

BUG=chromium:477684
Committed: https://skia.googlesource.com/skia/+/cd0749144383d78a10a5df00e2e96e76456b412b

[bsalomon, 2015-12-09 17:58:17]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-12-09 18:12:01]

lgtm

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
src/gpu/effects/GrRRectEffect.cpp:176: } else {
ditch the '\n' in the string ?
In the above string too ?

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
src/gpu/effects/GrRRectEffect.cpp:198: case
CircularRRectEffect::kAll_CornerFlags:
ditch the '\n's here too ?

[bsalomon, 2015-12-09 18:21:03]

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
src/gpu/effects/GrRRectEffect.cpp:176: } else {
On 2015/12/09 18:12:01, robertphillips wrote:
> ditch the '\n' in the string ?
> In the above string too ?

Done.

https://codereview.chromium.org/1517483002/diff/20001/src/gpu/effects/GrRRect...
src/gpu/effects/GrRRectEffect.cpp:198: case
CircularRRectEffect::kAll_CornerFlags:
On 2015/12/09 18:12:01, robertphillips wrote:
> ditch the '\n's here too ?

Done.

[bsalomon, 2015-12-09 18:21:07]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-09 18:21:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1517483002/#ps40001
(title: "Remove \n's")

[commit-bot: I haz the power, 2015-12-09 18:21:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517483002/40001

[commit-bot: I haz the power, 2015-12-09 18:33:54]

Description was changed from

==========
Prevent overflow in length() in GLCircularRRectEffect

BUG=chromium:477684
==========

to

==========
Prevent overflow in length() in GLCircularRRectEffect

BUG=chromium:477684

Committed:
https://skia.googlesource.com/skia/+/cd0749144383d78a10a5df00e2e96e76456b412b
==========

[commit-bot: I haz the power, 2015-12-09 18:33:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cd0749144383d78a10a5df00e2e96e76456b412b