Split big rrect aa effect up into separate images

Split big rrect aa effect up into separate images

Needed to enlarge radii to surface bugs without exceeding max texture size on low end devices.

BUG=chromium:477684
Committed: https://skia.googlesource.com/skia/+/4a4f14ba3f93cc6bb9146be0f029a9badb1b95d9

[bsalomon, 2015-12-09 17:04:41]

Description was changed from

==========
Split big rrect aa effect up into separate images


Update big_rrect_aa_effect GM to show bugs with larger radii

BUG=skia:
==========

to

==========
Split big rrect aa effect up into separate images

Needed to enlarge radii to surface bugs without exceeding max texture size on
low end devices.

BUG=chromium:477684
==========

[bsalomon, 2015-12-09 17:04:41]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-12-09 17:19:10]

lgtm + dox requests

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp
File gm/bigrrectaaeffect.cpp (right):

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:102: x = x + fTestOffsetX;
Do we need this wrap around code any more ?

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:112: static const int kPad = 5;
cap -> gap ?

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:127:
///////////////////////////////////////////////////////////////////////////////
// This value is motivated by bug XXX. It has to be large to cause underflow in
the shader

?

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:132: DEF_GM( return new BigRRectAAEffectGM
(SkRRect::MakeOval(SkRect::MakeWH(kSize - 1.f, kSize - 10.f)), "ellipse"); )
// The next two have small linear segments between the corners

[bsalomon, 2015-12-09 17:52:51]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-09 17:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1508003008/#ps20001
(title: "Address comments, increase gap and pad")

[commit-bot: I haz the power, 2015-12-09 17:52:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508003008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508003008/20001

[bsalomon, 2015-12-09 17:53:05]

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp
File gm/bigrrectaaeffect.cpp (right):

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:102: x = x + fTestOffsetX;
On 2015/12/09 17:19:09, robertphillips wrote:
> Do we need this wrap around code any more ?

Done.

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:112: static const int kPad = 5;
On 2015/12/09 17:19:09, robertphillips wrote:
> cap -> gap ?

Done.

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:127:
///////////////////////////////////////////////////////////////////////////////
On 2015/12/09 17:19:09, robertphillips wrote:
> // This value is motivated by bug XXX. It has to be large to cause underflow
in
> the shader
> 
> ?

Done.

https://codereview.chromium.org/1508003008/diff/1/gm/bigrrectaaeffect.cpp#new...
gm/bigrrectaaeffect.cpp:132: DEF_GM( return new BigRRectAAEffectGM
(SkRRect::MakeOval(SkRect::MakeWH(kSize - 1.f, kSize - 10.f)), "ellipse"); )
On 2015/12/09 17:19:09, robertphillips wrote:
> // The next two have small linear segments between the corners

Done.

[commit-bot: I haz the power, 2015-12-09 17:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 17:55:19]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2015-12-09 18:04:49]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-09 18:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1508003008/#ps40001
(title: "Fix int->scalar warnings")

[commit-bot: I haz the power, 2015-12-09 18:04:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508003008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508003008/40001

[commit-bot: I haz the power, 2015-12-09 18:17:37]

Description was changed from

==========
Split big rrect aa effect up into separate images

Needed to enlarge radii to surface bugs without exceeding max texture size on
low end devices.

BUG=chromium:477684
==========

to

==========
Split big rrect aa effect up into separate images

Needed to enlarge radii to surface bugs without exceeding max texture size on
low end devices.

BUG=chromium:477684

Committed:
https://skia.googlesource.com/skia/+/4a4f14ba3f93cc6bb9146be0f029a9badb1b95d9
==========

[commit-bot: I haz the power, 2015-12-09 18:17:38]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4a4f14ba3f93cc6bb9146be0f029a9badb1b95d9