Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517573002: Do elliptical clips in normalized space on devices with a "real" mediump (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@circlecorner
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do elliptical clips in normalized space on devices with a "real" mediump BUG=chromium:477684 Committed: https://skia.googlesource.com/skia/+/e87256c46291f7ce10f1d9a1d691d01ecf4eb3cc

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -41 lines) Patch
M src/gpu/effects/GrOvalEffect.cpp View 1 4 chunks +54 lines, -19 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 5 chunks +67 lines, -22 lines 0 comments Download

Depends on Patchset:

Issue 1517483002 Patch 40001

Messages

Total messages: 7 (3 generated)
bsalomon
5 years ago (2015-12-09 20:43:54 UTC) #2
jvanverth1
I was concerned that this would affect batching, but I realized that the same would ...
5 years ago (2015-12-09 21:38:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517573002/40001
5 years ago (2015-12-10 00:51:53 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 01:14:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e87256c46291f7ce10f1d9a1d691d01ecf4eb3cc

Powered by Google App Engine
This is Rietveld 408576698