Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1517043004: [mojo] Add typemap and variant support to generators (Closed)

Created:
5 years ago by Ken Rockot(use gerrit already)
Modified:
5 years ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pickle3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Add typemap and variant support to generators This introduces two new flags for the mojom bindings generator: --typemap can be used to provide typemap (JSON) files to the bindings generator. --variant specifies the name of the bindings variant to emit. Both of these new flags only affect C++ generation, and specifying --variant at all prevents JS or Java bindings from being emitted. Both of these new flags have GN mojom template variables associated with them as well. Part of a series of changes to support custom mojom serialization: 1. https://codereview.chromium.org/1515423002 2. This CL 3. https://codereview.chromium.org/1524693002 4. https://codereview.chromium.org/1520153002 5. https://codereview.chromium.org/1524613002 6. https://codereview.chromium.org/1526533002 7. https://codereview.chromium.org/1524703002 BUG=569669 Committed: https://crrev.com/103fd974609482f3179a7a2c15d2d21760524fb2 Cr-Commit-Position: refs/heads/master@{#365674}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 6

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Total comments: 1

Patch Set 9 : formatting #

Patch Set 10 : fix missing deps in variant targets #

Patch Set 11 : gyp deps #

Patch Set 12 : merge #

Patch Set 13 : merge fb suppressions #

Patch Set 14 : set proper upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -50 lines) Patch
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +34 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/blink_test.typemap View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/chromium_test.typemap View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 1 2 3 4 5 6 7 8 3 chunks +15 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 2 3 4 chunks +13 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 2 3 4 5 6 7 8 4 chunks +16 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +52 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 1 2 3 4 5 6 7 8 9 10 5 chunks +40 lines, -16 lines 0 comments Download
M mojo/public/tools/bindings/mojom_list_outputs.py View 1 2 3 4 5 6 7 1 chunk +17 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +61 lines, -0 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +37 lines, -7 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 1 2 3 4 5 6 7 2 chunks +16 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (18 generated)
Ken Rockot(use gerrit already)
Please take a look!
5 years ago (2015-12-14 18:40:57 UTC) #5
yzshen1
https://codereview.chromium.org/1517043004/diff/100001/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl File mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl (right): https://codereview.chromium.org/1517043004/diff/100001/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl#newcode12 mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl:12: format(variant_path|upper|replace("/","_")|replace(".","_")|replace("-", "_")) %} Please consider following the 80-char rule. ...
5 years ago (2015-12-15 00:09:10 UTC) #9
Ken Rockot(use gerrit already)
On 2015/12/15 at 00:09:10, yzshen wrote: > https://codereview.chromium.org/1517043004/diff/100001/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl > File mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl (right): > > https://codereview.chromium.org/1517043004/diff/100001/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl#newcode12 ...
5 years ago (2015-12-15 01:52:35 UTC) #10
yzshen1
> Hmm. I agree we should have tests but I think I'll defer to a ...
5 years ago (2015-12-15 23:02:53 UTC) #11
Ken Rockot(use gerrit already)
On 2015/12/15 at 23:02:53, yzshen wrote: > > Hmm. I agree we should have tests ...
5 years ago (2015-12-16 00:49:06 UTC) #12
yzshen1
On 2015/12/16 00:49:06, Ken Rockot wrote: > On 2015/12/15 at 23:02:53, yzshen wrote: > > ...
5 years ago (2015-12-16 00:52:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517043004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517043004/200001
5 years ago (2015-12-16 05:50:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/160400)
5 years ago (2015-12-16 07:08:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517043004/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517043004/220001
5 years ago (2015-12-16 17:19:47 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517043004/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517043004/250001
5 years ago (2015-12-16 21:51:30 UTC) #27
commit-bot: I haz the power
Committed patchset #14 (id:250001)
5 years ago (2015-12-16 23:46:26 UTC) #28
commit-bot: I haz the power
5 years ago (2015-12-16 23:47:11 UTC) #30
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/103fd974609482f3179a7a2c15d2d21760524fb2
Cr-Commit-Position: refs/heads/master@{#365674}

Powered by Google App Engine
This is Rietveld 408576698