[mojo] Add GenericInterface_ to interface class variants

[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
TBR=piman@chromium.org for content/gpu

Committed: https://crrev.com/54b524949599a2045114039133eb25b304e20359
Cr-Commit-Position: refs/heads/master@{#365708}

[Ken Rockot(use gerrit already), 2015-12-14 07:15:07]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This adds a GenericInterface_ type alias to generated
interface class variants and teaches some bindings
primitives about it.

BUG=
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1524613002
  2. https://codereview.chromium.org/1515423002
  3. https://codereview.chromium.org/1517043004
  4. https://codereview.chromium.org/1524693002
  5. https://codereview.chromium.org/1520153002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

[Ken Rockot(use gerrit already), 2015-12-14 07:15:24]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1524613002
  2. https://codereview.chromium.org/1515423002
  3. https://codereview.chromium.org/1517043004
  4. https://codereview.chromium.org/1524693002
  5. https://codereview.chromium.org/1520153002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1524613002
  2. https://codereview.chromium.org/1515423002
  3. https://codereview.chromium.org/1517043004
  4. This CL
  5. https://codereview.chromium.org/1520153002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

[Ken Rockot(use gerrit already), 2015-12-14 18:41:18]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2015-12-14 18:46:10]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1524613002
  2. https://codereview.chromium.org/1515423002
  3. https://codereview.chromium.org/1517043004
  4. This CL
  5. https://codereview.chromium.org/1520153002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1526533002
  6. https://codereview.chromium.org/1524703002

BUG=
==========

[Ken Rockot(use gerrit already), 2015-12-14 20:19:09]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1526533002
  6. https://codereview.chromium.org/1524703002

BUG=
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

[yzshen1, 2015-12-14 20:25:38]

https://codereview.chromium.org/1524693002/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/binding.h (right):

https://codereview.chromium.org/1524693002/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/binding.h:137: InterfaceRequest<GenericInterface_>
request,
InterfacePtr<>, AssociatedBinding<> and AssociatedInterfacePtr need the same
change, right?

https://codereview.chromium.org/1524693002/diff/20001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):

https://codereview.chromium.org/1524693002/diff/20001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:16:
using GenericInterface_ = {{interface|get_qualified_generic_interface_name}};
GenericInterface is something that could be used by bindings users, right? Maybe
we should remove the suffix '_'. '_' means something is supposed to be used by
the bindings internally.

(I think we have style issues with Name_ and Version_, too. But let's ignore
them for now.)

[Ken Rockot(use gerrit already), 2015-12-14 21:01:16]

On 2015/12/14 at 20:25:38, yzshen wrote:
>
https://codereview.chromium.org/1524693002/diff/20001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/binding.h (right):
> 
>
https://codereview.chromium.org/1524693002/diff/20001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/binding.h:137: InterfaceRequest<GenericInterface_>
request,
> InterfacePtr<>, AssociatedBinding<> and AssociatedInterfacePtr need the same
change, right?

Yeah, I wasn't sure about *InterfacePtrs, but I made some changes that I think
are appropriate. LMKWYT.

There's not really a sane way to support MakeProxy without forcing explicit
parameterization on callers, so I left those alone.

> 
>
https://codereview.chromium.org/1524693002/diff/20001/mojo/public/tools/bindi...
> File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):
> 
>
https://codereview.chromium.org/1524693002/diff/20001/mojo/public/tools/bindi...
>
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:16:
using GenericInterface_ = {{interface|get_qualified_generic_interface_name}};
> GenericInterface is something that could be used by bindings users, right?
Maybe we should remove the suffix '_'. '_' means something is supposed to be
used by the bindings internally.
> 
> (I think we have style issues with Name_ and Version_, too. But let's ignore
them for now.)

I agree! Changed to simply GenericInterface.

[Ken Rockot(use gerrit already), 2015-12-14 21:08:39]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
==========

[yzshen1, 2015-12-14 21:18:54]

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_interface_ptr.h (right):

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_interface_ptr.h:178:
AssociatedInterfaceRequest<Interface> GetProxy(
GenericInterface?

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/binding.h (right):

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/binding.h:193: return internal_state_.Unbind();
I think you have to make changes to BindingState, too.

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/1524693002/diff/40001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:74: return
"::".join(parts)
Does it need '::' at the beginning?

[Ken Rockot(use gerrit already), 2015-12-14 23:20:29]

On 2015/12/14 at 21:18:54, yzshen wrote:
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/associated_interface_ptr.h (right):
> 
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/associated_interface_ptr.h:178:
AssociatedInterfaceRequest<Interface> GetProxy(
> GenericInterface?

Fixed

> 
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/binding.h (right):
> 
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/binding.h:193: return internal_state_.Unbind();
> I think you have to make changes to BindingState, too.

Oops. Done!

> 
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/tools/bindi...
> File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):
> 
>
https://codereview.chromium.org/1524693002/diff/40001/mojo/public/tools/bindi...
> mojo/public/tools/bindings/generators/mojom_cpp_generator.py:74: return
"::".join(parts)
> Does it need '::' at the beginning?

Ah right, for types with no module specification. Done.

[yzshen1, 2015-12-14 23:58:26]

https://codereview.chromium.org/1524693002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_group.h (right):

https://codereview.chromium.org/1524693002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_group.h:49: AssociatedInterfacePtrInfo<T>*
ptr_info,
ptr_info should use the same type as the request, right?

InterfacePtrInfo <-> InterfacePtr is exactly the same relationship as
InterfaceRequest <-> Binding. So we probably don't want |ptr_info| to use a
"variant" type.

Therefore, it seems correct to leave this method untouched. WDYT?

https://codereview.chromium.org/1524693002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/associated_interface_ptr.h (right):

https://codereview.chromium.org/1524693002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/associated_interface_ptr.h:182:
AssociatedInterfacePtrInfo<Interface> ptr_info;
This should use GenericInterface.

https://codereview.chromium.org/1524693002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/1524693002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:71: parts = [""]
Please comment on why having "" there.

[Ken Rockot(use gerrit already), 2015-12-15 00:06:35]

On 2015/12/14 at 23:58:26, yzshen wrote:
>
https://codereview.chromium.org/1524693002/diff/60001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/associated_group.h (right):
> 
>
https://codereview.chromium.org/1524693002/diff/60001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/associated_group.h:49: AssociatedInterfacePtrInfo<T>*
ptr_info,
> ptr_info should use the same type as the request, right?
> 
> InterfacePtrInfo <-> InterfacePtr is exactly the same relationship as
InterfaceRequest <-> Binding. So we probably don't want |ptr_info| to use a
"variant" type.
> 
> Therefore, it seems correct to leave this method untouched. WDYT?

Ah I agree. Done.

> 
>
https://codereview.chromium.org/1524693002/diff/80001/mojo/public/cpp/binding...
> File mojo/public/cpp/bindings/associated_interface_ptr.h (right):
> 
>
https://codereview.chromium.org/1524693002/diff/80001/mojo/public/cpp/binding...
> mojo/public/cpp/bindings/associated_interface_ptr.h:182:
AssociatedInterfacePtrInfo<Interface> ptr_info;
> This should use GenericInterface.

Oops, Done.

> 
>
https://codereview.chromium.org/1524693002/diff/80001/mojo/public/tools/bindi...
> File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):
> 
>
https://codereview.chromium.org/1524693002/diff/80001/mojo/public/tools/bindi...
> mojo/public/tools/bindings/generators/mojom_cpp_generator.py:71: parts = [""]
> Please comment on why having "" there.

Done!

[yzshen1, 2015-12-15 00:10:10]

lgtm

[Ken Rockot(use gerrit already), 2015-12-16 00:53:56]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
==========

[Ken Rockot(use gerrit already), 2015-12-16 02:32:15]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
TBR=piman@chromium.org for content/gpu
==========

[Ken Rockot(use gerrit already), 2015-12-16 21:54:51]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-12-16 21:54:52]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1524693002/#ps220001
(title: "merge")

[commit-bot: I haz the power, 2015-12-16 21:57:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 21:57:01]

This CL has an open dependency (Issue 1517043004 Patch 250001). Please resolve
the dependency and try again.

[Ken Rockot(use gerrit already), 2015-12-16 23:48:33]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-12-16 23:50:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1524693002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1524693002/220001

[commit-bot: I haz the power, 2015-12-17 03:22:10]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-12-17 03:24:14]

Description was changed from

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
TBR=piman@chromium.org for content/gpu
==========

to

==========
[mojo] Add GenericInterface_ to interface class variants

This is used to identify pure non-variant interface
definitions for uses relevant to InterfaceRequest.

e.g. one could do

  variant1::FooPtr foo;
  GetProxy(&foo)

and GetProxy will return an InterfaceRequest<generic::Foo>.

Part of a series of changes to support custom mojom serialization:

  1. https://codereview.chromium.org/1515423002
  2. https://codereview.chromium.org/1517043004
  3. This CL
  4. https://codereview.chromium.org/1520153002
  5. https://codereview.chromium.org/1524613002
  6. https://codereview.chromium.org/1526533002
  7. https://codereview.chromium.org/1524703002

BUG=569669
TBR=sky@chromium.org for mojo/common
TBR=piman@chromium.org for content/gpu

Committed: https://crrev.com/54b524949599a2045114039133eb25b304e20359
Cr-Commit-Position: refs/heads/master@{#365708}
==========

[commit-bot: I haz the power, 2015-12-17 03:24:14]

Patchset 12 (id:??) landed as
https://crrev.com/54b524949599a2045114039133eb25b304e20359
Cr-Commit-Position: refs/heads/master@{#365708}