Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 1529093004: [mojo] Suppress findbugs errors on generated bindings (Closed)

Created:
5 years ago by Ken Rockot(use gerrit already)
Modified:
5 years ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Suppress findbugs errors on generated bindings The Java bindings haven't changed for quite some time, so either due to changes in findbugs or to what targets we run findbugs on, these errors have started popping up and blocking try jobs. This suppresses them for now until more investigation can be done. BUG=570386 TBR=yzshen@chromium.org Committed: https://crrev.com/206fbc4fe87bb5cd0b599c38cf5aac278329d575 Cr-Commit-Position: refs/heads/master@{#365627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M mojo/public/java/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/header.java.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
5 years ago (2015-12-16 20:29:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529093004/1
5 years ago (2015-12-16 20:29:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 21:46:49 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-16 21:47:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/206fbc4fe87bb5cd0b599c38cf5aac278329d575
Cr-Commit-Position: refs/heads/master@{#365627}

Powered by Google App Engine
This is Rietveld 408576698