Issue 1516103003: Add the RSC instruction to the ARM integrated assembler.

Issue 1516103003: Add the RSC instruction to the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl

Modified:
5 years ago

Reviewers:
sehr (please use chromium), Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add the RSC instruction to the ARM integrated assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=337ac9e775203b2449d7020931dc58f29d55cd44

Patch Set 2 : Add Dart source. #

Total comments: 2

Patch Set 3 : Fix nit. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -5 lines)			Patch
M	src/DartARM32/assembler_arm.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/DartARM32/assembler_arm.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/IceAssemblerARM32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View		2 chunks	+27 lines, -1 line	0 comments	Download
M	src/IceInstARM32.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	tests_lit/assembler/arm32/rsc.ll	View	1 2	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1516103003/diff/20001/tests_lit/assembler/arm32/rsc.ll File tests_lit/assembler/arm32/rsc.ll (right): https://codereview.chromium.org/1516103003/diff/20001/tests_lit/assembler/arm32/rsc.ll#newcode1 tests_lit/assembler/arm32/rsc.ll:1: ; Show that we know how to translate ...

5 years ago (2015-12-11 16:50:09 UTC) #5

Karl

Committed patchset #3 (id:40001) manually as 337ac9e775203b2449d7020931dc58f29d55cd44 (presubmit successful).

5 years ago (2015-12-11 17:12:11 UTC) #7

Karl

5 years ago (2015-12-11 17:12:26 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/1516103003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/rsc.ll (right):

https://codereview.chromium.org/1516103003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/rsc.ll:1: ; Show that we know how to translate add.
On 2015/12/11 16:50:09, stichnot wrote:
> rsc

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages