Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1515963005:
SVGImage: check requestCount() to check all subresources are loaded (Closed)
|
Created:
5 years ago by hiroshige Modified:
3 years, 7 months ago Reviewers:
kouhei (in TOK) CC:
chromium-reviews, tyoshino+watch_chromium.org, krit, rwlbuis, fs, kouhei+svg_chromium.org, loading-reviews_chromium.org, f(malita), gavinp+loader_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, Nate Chapin, pdr+svgwatchlist_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSVGImage: check requestCount() to check all subresources are loaded
Document::loadEventFinished() was used to check all subresources of SVG are
loaded in RELEASE_ASSERT() added by
https://chromiumcodereview.appspot.com/22999031.
However, it is sufficient to check that ResourceFetcher::requestCount() is
zero and we don't have to wait load event completion of the SVG document.
This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount().
Also, this CL checks the assertion in ImageLoader::notifyFinished(), because
currentFrameHasSingleSecurityOrigin() can be called anytime after
|ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus
the assertion must hold at that point.
This is preparation for https://codereview.chromium.org/1475863005/, which
will invoke SVG Document's load event async and thus the load event completion
can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called.
This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs
for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5].
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
https://codereview.chromium.org/1515963005/ (This CL)
BUG=382170, 569511
Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b
Cr-Commit-Position: refs/heads/master@{#365164}
Patch Set 1 #Patch Set 2 : ASSERT(m_page) #Patch Set 3 : Rebase. #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : Rebase. #Patch Set 7 : Rebase. #Patch Set 8 : #Patch Set 9 : Rebase #Patch Set 10 : Rebase. #Patch Set 11 : auto-Rebase #
Depends on Patchset: Messages
Total messages: 52 (28 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Async][WIP] Check ResourceFetcher::requestCount() in SVGImage to check all subresources are loaded The RELEASE_ASSERT is added by https://chromiumcodereview.appspot.com/22999031 to check all subresources of SVG is loaded. However, it is sufficient to check that there are no pending subresource loading. This CL changes the RELEASE_ASSERT, and also check the condition in ImageResource::notifyFinished(). BUG= ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anywhere after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ==========
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anywhere after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ==========
hiroshige@chromium.org changed reviewers: + kouhei@chromium.org
PTAL.
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/20001
Message was sent while issue was closed.
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1544473004/ by hiroshige@chromium.org. The reason for reverting is: The RELEASE_ASSERT fails reproducibly and causes crashes in the wild. https://crbug.com/571515 .
Message was sent while issue was closed.
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=569511 Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=382170, 569511 This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5]. [1/5] Make fonts with data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1700233003/ [2/5] Do not reload FontResource created by resourceForStaticData(). https://codereview.chromium.org/1704693002/ [3/5] Make invalid data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1707013002/ [4/5] Add layout tests. https://codereview.chromium.org/1699323002/ [5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished(). https://codereview.chromium.org/1515963005/ (This CL) Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ==========
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=382170, 569511 This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5]. [1/5] Make fonts with data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1700233003/ [2/5] Do not reload FontResource created by resourceForStaticData(). https://codereview.chromium.org/1704693002/ [3/5] Make invalid data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1707013002/ [4/5] Add layout tests. https://codereview.chromium.org/1699323002/ [5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished(). https://codereview.chromium.org/1515963005/ (This CL) Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=382170, 569511 This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5]. [1/5] Make fonts with data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1700233003/ [2/5] Do not reload FontResource created by resourceForStaticData(). https://codereview.chromium.org/1704693002/ [3/5] Make invalid data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1707013002/ [4/5] Add layout tests. https://codereview.chromium.org/1699323002/ [5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished(). https://codereview.chromium.org/1515963005/ (This CL) Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ==========
Description was changed from ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. BUG=382170, 569511 This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5]. [1/5] Make fonts with data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1700233003/ [2/5] Do not reload FontResource created by resourceForStaticData(). https://codereview.chromium.org/1704693002/ [3/5] Make invalid data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1707013002/ [4/5] Add layout tests. https://codereview.chromium.org/1699323002/ [5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished(). https://codereview.chromium.org/1515963005/ (This CL) Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ========== to ========== SVGImage: check requestCount() to check all subresources are loaded Document::loadEventFinished() was used to check all subresources of SVG are loaded in RELEASE_ASSERT() added by https://chromiumcodereview.appspot.com/22999031. However, it is sufficient to check that ResourceFetcher::requestCount() is zero and we don't have to wait load event completion of the SVG document. This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). Also, this CL checks the assertion in ImageLoader::notifyFinished(), because currentFrameHasSingleSecurityOrigin() can be called anytime after |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus the assertion must hold at that point. This is preparation for https://codereview.chromium.org/1475863005/, which will invoke SVG Document's load event async and thus the load event completion can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. This CL is reverted due to Issue 382170, and will be relanded as [5/5] of CLs for Issue 382170, after the issue is fixed by [1/5], [2/5], and [3/5]. [1/5] Make fonts with data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1700233003/ [2/5] Do not reload FontResource created by resourceForStaticData(). https://codereview.chromium.org/1704693002/ [3/5] Make invalid data: URLs to be served by resourceForStaticData(). https://codereview.chromium.org/1707013002/ [4/5] Add layout tests. https://codereview.chromium.org/1699323002/ [5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished(). https://codereview.chromium.org/1515963005/ (This CL) BUG=382170, 569511 Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b Cr-Commit-Position: refs/heads/master@{#365164} ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515963005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515963005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
