Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1544473004: Revert of SVGImage: check requestCount() to check all subresources are loaded (Closed)

Created:
5 years ago by hiroshige
Modified:
5 years ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, tyoshino+watch_chromium.org, krit, rwlbuis, fs, kouhei+svg_chromium.org, loading-reviews_chromium.org, f(malita), gavinp+loader_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, Nate Chapin, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SVGImage: check requestCount() to check all subresources are loaded (patchset #2 id:20001 of https://codereview.chromium.org/1515963005/ ) Reason for revert: The RELEASE_ASSERT fails reproducibly and causes crashes in the wild. https://crbug.com/571515 Original issue's description: > SVGImage: check requestCount() to check all subresources are loaded > > Document::loadEventFinished() was used to check all subresources of SVG are > loaded in RELEASE_ASSERT() added by > https://chromiumcodereview.appspot.com/22999031. > However, it is sufficient to check that ResourceFetcher::requestCount() is > zero and we don't have to wait load event completion of the SVG document. > > This CL changes the RELEASE_ASSERT() to check ResourceFetcher::requestCount(). > > Also, this CL checks the assertion in ImageLoader::notifyFinished(), because > currentFrameHasSingleSecurityOrigin() can be called anytime after > |ImageLoader::m_imageComplete| is set to true in notifyFinished() and thus > the assertion must hold at that point. > > This is preparation for https://codereview.chromium.org/1475863005/, which > will invoke SVG Document's load event async and thus the load event completion > can be after SVGImage::currentFrameHasSingleSecurityOrigin() is called. > > BUG=569511 > > Committed: https://crrev.com/3065748ccfc14c45da2e151348b85d34d94bf76b > Cr-Commit-Position: refs/heads/master@{#365164} TBR=kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569511 Committed: https://crrev.com/8a1fcdb2aa873f0fb81e937c4e97156d41351735 Cr-Commit-Position: refs/heads/master@{#366529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hiroshige
Created Revert of SVGImage: check requestCount() to check all subresources are loaded
5 years ago (2015-12-22 02:58:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544473004/1
5 years ago (2015-12-22 02:59:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 03:00:15 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-22 03:01:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1fcdb2aa873f0fb81e937c4e97156d41351735
Cr-Commit-Position: refs/heads/master@{#366529}

Powered by Google App Engine
This is Rietveld 408576698