Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 1509843002: Remove bogus include from v8.h header. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove bogus include from v8.h header. This was introduced due to a false positive by the linter script. We have blacklisted the "build/include_what_you_use" linter bucket in our presubmit.py wrapper for that reason. R=jochen@chromium.org Committed: https://crrev.com/6422994f9031c70853df1063f6906571fa5e6150 Cr-Commit-Position: refs/heads/master@{#32679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M include/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Michael Starzinger
Jochen: PTAL. Dan: FYI.
5 years ago (2015-12-08 09:42:25 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-08 09:42:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509843002/1
5 years ago (2015-12-08 09:43:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/11096)
5 years ago (2015-12-08 10:23:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509843002/1
5 years ago (2015-12-08 16:33:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 18:59:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-08 18:59:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6422994f9031c70853df1063f6906571fa5e6150
Cr-Commit-Position: refs/heads/master@{#32679}

Powered by Google App Engine
This is Rietveld 408576698