[turbofan] Don't run graph verifier on scheduled graphs.

[turbofan] Don't run graph verifier on scheduled graphs.

Fully scheduled graphs built by the RawMachineAssembler are inherently
not schedulable, they are missing effect and control dependencies, which
makes them not pass the graph verifier either. They do however pass the
schedule verifier.

R=titzer@chromium.org

Committed: https://crrev.com/f9ea078a22104a0e035c9948751205ea6d9ef424
Cr-Commit-Position: refs/heads/master@{#32715}

[Michael Starzinger, 2015-12-08 17:19:04]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2015-12-08 17:19:04]

Ben: PTAL.
Ross: FYI.

[rmcilroy, 2015-12-08 17:26:35]

https://codereview.chromium.org/1505233003/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (left):

https://codereview.chromium.org/1505233003/diff/1/src/compiler/pipeline.cc#ol...
src/compiler/pipeline.cc:1242: pipeline.RunPrintAndVerify("Machine", true);
This change also means that --trace-turbo no longer works on these graphs. Is
there anyway we could seperate the Print and Verify steps to allow Print to
continue but Verify to be skipped?

[Michael Starzinger, 2015-12-08 17:37:34]

https://codereview.chromium.org/1505233003/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (left):

https://codereview.chromium.org/1505233003/diff/1/src/compiler/pipeline.cc#ol...
src/compiler/pipeline.cc:1242: pipeline.RunPrintAndVerify("Machine", true);
On 2015/12/08 17:26:35, rmcilroy wrote:
> This change also means that --trace-turbo no longer works on these graphs. Is
> there anyway we could seperate the Print and Verify steps to allow Print to
> continue but Verify to be skipped?

Done.

[rmcilroy, 2015-12-08 17:53:54]

Lgtm, thanks! I'll remove the extra node inputs in RMA tomorrow (if you don't
get to it first).

[Benedikt Meurer, 2015-12-09 10:20:55]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-12-09 10:20:55]

LGTM (rubberstamped)

[Michael Starzinger, 2015-12-09 10:24:07]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-09 10:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505233003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505233003/20001

[commit-bot: I haz the power, 2015-12-09 10:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 10:58:12]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Michael Starzinger, 2015-12-09 13:51:25]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-09 13:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505233003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505233003/20001

[commit-bot: I haz the power, 2015-12-09 14:09:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 14:09:56]

Description was changed from

==========
[turbofan] Don't run graph verifier on scheduled graphs.

Fully scheduled graphs built by the RawMachineAssembler are inherently
not schedulable, they are missing effect and control dependencies, which
makes them not pass the graph verifier either. They do however pass the
schedule verifier.

R=titzer@chromium.org
==========

to

==========
[turbofan] Don't run graph verifier on scheduled graphs.

Fully scheduled graphs built by the RawMachineAssembler are inherently
not schedulable, they are missing effect and control dependencies, which
makes them not pass the graph verifier either. They do however pass the
schedule verifier.

R=titzer@chromium.org

Committed: https://crrev.com/f9ea078a22104a0e035c9948751205ea6d9ef424
Cr-Commit-Position: refs/heads/master@{#32715}
==========

[commit-bot: I haz the power, 2015-12-09 14:09:57]

Patchset 2 (id:??) landed as
https://crrev.com/f9ea078a22104a0e035c9948751205ea6d9ef424
Cr-Commit-Position: refs/heads/master@{#32715}