Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1514863002: [turbofan] Make FieldAccess::name usable in practice.

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make FieldAccess::name usable in practice. This debugging only field was mostly unpopulated because it required names to be allocated in the heap. Changing it to a raw C-string allows passing sensible values without having access to the heap. R=bmeurer@chromium.org

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -84 lines) Patch
M src/compiler/access-builder.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 29 chunks +59 lines, -39 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -7 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 11 chunks +21 lines, -24 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
Michael Starzinger
5 years ago (2015-12-10 14:15:36 UTC) #1
Michael Starzinger
5 years ago (2015-12-10 14:53:12 UTC) #2
As per offline discussion: I learned that we want to potentially use the
{FieldAccess::name} value for alias analysis. Then it makes sense to keep it
Handle<Name> type. But we need to make sure it is always properly populated. I
will rework this CL accordingly.

Powered by Google App Engine
This is Rietveld 408576698