Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506233008: [presubmit] Enable readability/nolint linter checking. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Enable readability/nolint linter checking. R=jochen@chromium.org Committed: https://crrev.com/cdafea20119f13b3fca24530513e8fa135cfd36e Cr-Commit-Position: refs/heads/master@{#32745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/arm64/constants-arm64.h View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1509843002 Patch 1

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-12-10 09:25:10 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-10 10:12:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506233008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506233008/1
5 years ago (2015-12-10 10:21:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 10:41:41 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 10:41:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cdafea20119f13b3fca24530513e8fa135cfd36e
Cr-Commit-Position: refs/heads/master@{#32745}

Powered by Google App Engine
This is Rietveld 408576698