Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1502233005: Don't explicitly turn on -Wendif-labels. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't explicitly turn on -Wendif-labels. It's enabled by default both in clang and in recent gccs. BUG=none Committed: https://crrev.com/4626ac3123ef9c7a139b815429d15d4c7ded7e36 Cr-Commit-Position: refs/heads/master@{#364440}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nico
5 years ago (2015-12-08 22:12:50 UTC) #2
brettw
lgtm
5 years ago (2015-12-10 17:46:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502233005/1
5 years ago (2015-12-10 17:50:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/106133) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-10 17:52:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502233005/20001
5 years ago (2015-12-10 17:56:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 19:52:09 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 19:53:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4626ac3123ef9c7a139b815429d15d4c7ded7e36
Cr-Commit-Position: refs/heads/master@{#364440}

Powered by Google App Engine
This is Rietveld 408576698