Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: build/common.gypi

Issue 1502233005: Don't explicitly turn on -Wendif-labels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5056 matching lines...) Expand 10 before | Expand all | Expand 10 after
5067 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 5067 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
5068 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 5068 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
5069 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden 5069 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5070 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 5070 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
5071 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 5071 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
5072 'GCC_VERSION': '4.2', 5072 'GCC_VERSION': '4.2',
5073 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 5073 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
5074 'USE_HEADERMAP': 'NO', 5074 'USE_HEADERMAP': 'NO',
5075 'WARNING_CFLAGS': [ 5075 'WARNING_CFLAGS': [
5076 '-Wall', 5076 '-Wall',
5077 '-Wendif-labels',
5078 '-Wextra', 5077 '-Wextra',
5079 # Don't warn about unused function parameters. 5078 # Don't warn about unused function parameters.
5080 '-Wno-unused-parameter', 5079 '-Wno-unused-parameter',
5081 # Don't warn about the "struct foo f = {0};" initialization 5080 # Don't warn about the "struct foo f = {0};" initialization
5082 # pattern. 5081 # pattern.
5083 '-Wno-missing-field-initializers', 5082 '-Wno-missing-field-initializers',
5084 ], 5083 ],
5085 'conditions': [ 5084 'conditions': [
5086 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, 5085 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
5087 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} 5086 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
(...skipping 1315 matching lines...) Expand 10 before | Expand all | Expand 10 after
6403 # settings in target dicts. SYMROOT is a special case, because many other 6402 # settings in target dicts. SYMROOT is a special case, because many other
6404 # Xcode variables depend on it, including variables such as 6403 # Xcode variables depend on it, including variables such as
6405 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6404 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6406 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6405 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6407 # files to appear (when present) in the UI as actual files and not red 6406 # files to appear (when present) in the UI as actual files and not red
6408 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6407 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6409 # and therefore SYMROOT, needs to be set at the project level. 6408 # and therefore SYMROOT, needs to be set at the project level.
6410 'SYMROOT': '<(DEPTH)/xcodebuild', 6409 'SYMROOT': '<(DEPTH)/xcodebuild',
6411 }, 6410 },
6412 } 6411 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698