Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1502233005: Don't explicitly turn on -Wendif-labels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 # Don't warn about the "typedef 'foo' locally defined but not used" 816 # Don't warn about the "typedef 'foo' locally defined but not used"
817 # for gcc 4.8. 817 # for gcc 4.8.
818 # TODO: remove this flag once all builds work. See crbug.com/227506 818 # TODO: remove this flag once all builds work. See crbug.com/227506
819 cflags += [ "-Wno-unused-local-typedefs" ] 819 cflags += [ "-Wno-unused-local-typedefs" ]
820 } 820 }
821 } 821 }
822 822
823 # Common Clang and GCC warning setup. 823 # Common Clang and GCC warning setup.
824 if (!is_win || is_clang) { 824 if (!is_win || is_clang) {
825 cflags += [ 825 cflags += [
826 # Enables.
827 "-Wendif-labels", # Weird old-style text after an #endif.
828
829 # Disables. 826 # Disables.
830 "-Wno-missing-field-initializers", # "struct foo f = {0};" 827 "-Wno-missing-field-initializers", # "struct foo f = {0};"
831 "-Wno-unused-parameter", # Unused function parameters. 828 "-Wno-unused-parameter", # Unused function parameters.
832 ] 829 ]
833 } 830 }
834 831
835 if (is_clang) { 832 if (is_clang) {
836 cflags += [ 833 cflags += [
837 # This warns on using ints as initializers for floats in 834 # This warns on using ints as initializers for floats in
838 # initializer lists (e.g. |int a = f(); CGSize s = { a, a };|), 835 # initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1311 if (symbol_level == 0) { 1308 if (symbol_level == 0) {
1312 configs = [ ":no_symbols" ] 1309 configs = [ ":no_symbols" ]
1313 } else if (symbol_level == 1) { 1310 } else if (symbol_level == 1) {
1314 configs = [ ":minimal_symbols" ] 1311 configs = [ ":minimal_symbols" ]
1315 } else if (symbol_level == 2) { 1312 } else if (symbol_level == 2) {
1316 configs = [ ":symbols" ] 1313 configs = [ ":symbols" ]
1317 } else { 1314 } else {
1318 assert(false) 1315 assert(false)
1319 } 1316 }
1320 } 1317 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698