build/config/compiler/BUILD.gn - Issue 1502233005: Don't explicitly turn on -Wendif-labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1502233005: Don't explicitly turn on -Wendif-labels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 10148bdb0771742e4ac784ca7980776a6ba026ed..e817fd4ba4bea06d9f2caf899cacdd021d39b69e 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -823,9 +823,6 @@ config("default_warnings") {

# Common Clang and GCC warning setup.

if (!is_win || is_clang) {

cflags += [

- # Enables.

- "-Wendif-labels", # Weird old-style text after an #endif.

# Disables.

"-Wno-missing-field-initializers", # "struct foo f = {0};"

"-Wno-unused-parameter", # Unused function parameters.

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »