Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1501073002: Implement LSR instructions for the integrated ARM assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement LSR instructions for the integrated ARM assembler. Also factors out the body of method lsl() to emitShift(), so that all forms of shift instructions can use the same code. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4ddce702d86894de5d7e60ed0178df86ed2e7dd1

Patch Set 1 #

Patch Set 2 : Reformat and remove dead code. #

Patch Set 3 : Add comments to dart code to show port. #

Total comments: 2

Patch Set 4 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -51 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 3 1 chunk +38 lines, -25 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A + tests_lit/assembler/arm32/lsr.ll View 1 2 3 2 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
5 years ago (2015-12-04 23:00:52 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1501073002/diff/40001/tests_lit/assembler/arm32/lsr.ll File tests_lit/assembler/arm32/lsr.ll (right): https://codereview.chromium.org/1501073002/diff/40001/tests_lit/assembler/arm32/lsr.ll#newcode32 tests_lit/assembler/arm32/lsr.ll:32: %shl = lshr i32 %a, 23 Maybe you ...
5 years ago (2015-12-04 23:39:12 UTC) #4
Karl
Committed patchset #4 (id:60001) manually as 4ddce702d86894de5d7e60ed0178df86ed2e7dd1 (presubmit successful).
5 years ago (2015-12-07 18:43:38 UTC) #6
Karl
5 years ago (2015-12-07 18:44:00 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1501073002/diff/40001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/lsr.ll (right):

https://codereview.chromium.org/1501073002/diff/40001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/lsr.ll:32: %shl = lshr i32 %a, 23
On 2015/12/04 23:39:12, stichnot wrote:
> Maybe you want to rename this var?

Done.

Powered by Google App Engine
This is Rietveld 408576698