Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1499423004: Remove kint32max. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, dcheng, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, pvalenzuela+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org, jennb, jianli, feature-media-reviews_chromium.org, piman+watch_chromium.org, michaeln, tfarina, maxbogue+watch_chromium.org, shuchen+watch_chromium.org, Dmitry Titov, plaree+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kint9
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kint32max. BUG=138542, 488550 Committed: https://crrev.com/d0181f31d10f5126e836fd38bd6bf54d4c4d4872 Cr-Commit-Position: refs/heads/master@{#364429}

Patch Set 1 #

Patch Set 2 : const #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Total comments: 7

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Total comments: 4

Patch Set 9 : media codec bridges #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+889 lines, -708 lines) Patch
M apps/saved_files_service.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M base/basictypes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/files/memory_mapped_file.h View 5 chunks +10 lines, -10 lines 0 comments Download
M base/files/memory_mapped_file.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M base/files/memory_mapped_file_posix.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M base/files/memory_mapped_file_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/files/memory_mapped_file_win.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M base/json/string_escape.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M base/strings/string_util.cc View 1 2 3 4 5 6 6 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_controller.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader.cc View 2 chunks +5 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_disk_cache.h View 3 chunks +10 lines, -6 lines 0 comments Download
M content/browser/appcache/appcache_disk_cache.cc View 11 chunks +22 lines, -18 lines 0 comments Download
M content/browser/appcache/appcache_response.h View 8 chunks +38 lines, -25 lines 0 comments Download
M content/browser/appcache/appcache_response.cc View 6 chunks +25 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.h View 1 2 3 4 5 6 5 chunks +8 lines, -6 lines 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/mac/font_loader.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/mac/font_loader.mm View 5 chunks +12 lines, -9 lines 0 comments Download
M content/public/common/context_menu_params.h View 4 chunks +5 lines, -3 lines 0 comments Download
M content/public/common/context_menu_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_storage/dom_storage_cached_area.h View 3 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_cached_area.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/test/fileapi_test_file_set.cc View 2 chunks +4 lines, -1 line 0 comments Download
M media/base/android/media_codec_bridge.h View 1 2 3 4 5 6 6 chunks +7 lines, -5 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 2 3 4 5 6 3 chunks +3 lines, -4 lines 0 comments Download
M media/base/android/ndk_media_codec_bridge.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -3 lines 0 comments Download
M media/base/android/ndk_media_codec_bridge.cc View 1 2 3 4 5 6 7 8 6 chunks +15 lines, -9 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.h View 1 2 3 4 5 6 7 8 6 chunks +15 lines, -13 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 1 2 3 4 5 6 7 8 16 chunks +35 lines, -30 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 2 chunks +4 lines, -1 line 0 comments Download
M media/formats/mp4/box_reader.h View 7 chunks +34 lines, -29 lines 0 comments Download
M media/formats/mp4/box_reader.cc View 10 chunks +36 lines, -25 lines 0 comments Download
M net/disk_cache/blockfile/backend_worker_v3.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/entry_impl.h View 7 chunks +21 lines, -15 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl.cc View 15 chunks +32 lines, -19 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl_v3.h View 6 chunks +13 lines, -11 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl_v3.cc View 15 chunks +40 lines, -21 lines 0 comments Download
M net/disk_cache/blockfile/eviction.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/eviction_v3.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3.h View 11 chunks +32 lines, -27 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3.cc View 25 chunks +66 lines, -66 lines 0 comments Download
M net/disk_cache/blockfile/rankings.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/disk_cache/cache_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/cache_util.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.h View 16 chunks +42 lines, -42 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 34 chunks +66 lines, -70 lines 0 comments Download
M net/http/mock_http_cache.h View 4 chunks +8 lines, -6 lines 0 comments Download
M net/http/mock_http_cache.cc View 9 chunks +13 lines, -11 lines 0 comments Download
M net/http/partial_data.h View 2 chunks +8 lines, -6 lines 0 comments Download
M net/http/partial_data.cc View 10 chunks +20 lines, -17 lines 0 comments Download
M net/spdy/spdy_session.h View 13 chunks +22 lines, -19 lines 0 comments Download
M net/spdy/spdy_session.cc View 23 chunks +36 lines, -35 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 6 chunks +15 lines, -11 lines 0 comments Download
M ppapi/shared_impl/id_assignment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/color_analysis.cc View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1502503004 Patch 160001

Messages

Total messages: 62 (25 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/1
5 years ago (2015-12-05 19:50:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/20001
5 years ago (2015-12-05 19:53:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/66248)
5 years ago (2015-12-05 20:21:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/40001
5 years ago (2015-12-05 20:23:00 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/153668)
5 years ago (2015-12-05 20:51:55 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/60001
5 years ago (2015-12-06 00:50:35 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/150970)
5 years ago (2015-12-06 02:20:32 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/80001
5 years ago (2015-12-06 04:58:50 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/140511)
5 years ago (2015-12-06 06:25:59 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/100001
5 years ago (2015-12-06 18:36:08 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/150745)
5 years ago (2015-12-06 19:59:07 UTC) #22
Avi (use Gerrit)
mark: base/ and ui/ asargent: apps/ sky: chrome/ and content/ vitalybuka: cloud_print/ dalecurtis: media/ mmenke: ...
5 years ago (2015-12-06 20:47:56 UTC) #24
Avi (use Gerrit)
5 years ago (2015-12-06 20:48:37 UTC) #26
raymes
ppapi/ rubberstamp lgtm
5 years ago (2015-12-06 23:13:36 UTC) #27
raymes
https://codereview.chromium.org/1499423004/diff/100001/ppapi/shared_impl/id_assignment.cc File ppapi/shared_impl/id_assignment.cc (right): https://codereview.chromium.org/1499423004/diff/100001/ppapi/shared_impl/id_assignment.cc#newcode13 ppapi/shared_impl/id_assignment.cc:13: const int32_t kMaxPPId = INT32_MAX >> kPPIdTypeBits; Hmm why ...
5 years ago (2015-12-06 23:16:35 UTC) #28
Avi (use Gerrit)
https://codereview.chromium.org/1499423004/diff/100001/ppapi/shared_impl/id_assignment.cc File ppapi/shared_impl/id_assignment.cc (right): https://codereview.chromium.org/1499423004/diff/100001/ppapi/shared_impl/id_assignment.cc#newcode13 ppapi/shared_impl/id_assignment.cc:13: const int32_t kMaxPPId = INT32_MAX >> kPPIdTypeBits; On 2015/12/06 ...
5 years ago (2015-12-06 23:50:30 UTC) #29
Mark Mentovai
LGTM in base and ui https://codereview.chromium.org/1499423004/diff/100001/base/basictypes.h File base/basictypes.h (left): https://codereview.chromium.org/1499423004/diff/100001/base/basictypes.h#oldcode26 base/basictypes.h:26: // DEPRECATED: Use std::numeric_limits ...
5 years ago (2015-12-07 15:06:48 UTC) #30
mmenke
net/ LGTM https://codereview.chromium.org/1499423004/diff/100001/net/disk_cache/blockfile/backend_worker_v3.cc File net/disk_cache/blockfile/backend_worker_v3.cc (right): https://codereview.chromium.org/1499423004/diff/100001/net/disk_cache/blockfile/backend_worker_v3.cc#newcode6 net/disk_cache/blockfile/backend_worker_v3.cc:6: #include <limits> https://codereview.chromium.org/1499423004/diff/100001/net/http/partial_data.h File net/http/partial_data.h (right): https://codereview.chromium.org/1499423004/diff/100001/net/http/partial_data.h#newcode10 ...
5 years ago (2015-12-07 16:15:22 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/120001
5 years ago (2015-12-07 16:18:50 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/140001
5 years ago (2015-12-07 16:33:59 UTC) #35
Avi (use Gerrit)
https://codereview.chromium.org/1499423004/diff/100001/net/disk_cache/blockfile/backend_worker_v3.cc File net/disk_cache/blockfile/backend_worker_v3.cc (right): https://codereview.chromium.org/1499423004/diff/100001/net/disk_cache/blockfile/backend_worker_v3.cc#newcode6 net/disk_cache/blockfile/backend_worker_v3.cc:6: On 2015/12/07 16:15:22, mmenke wrote: > #include <limits> Can't ...
5 years ago (2015-12-07 16:42:33 UTC) #36
sky
LGTM assuming the two uses of INT32_MAX are correct. https://codereview.chromium.org/1499423004/diff/140001/content/common/gpu/media/android_video_encode_accelerator.h File content/common/gpu/media/android_video_encode_accelerator.h (right): https://codereview.chromium.org/1499423004/diff/140001/content/common/gpu/media/android_video_encode_accelerator.h#newcode59 content/common/gpu/media/android_video_encode_accelerator.h:59: ...
5 years ago (2015-12-07 16:43:46 UTC) #37
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/154004) android_chromium_gn_compile_dbg on ...
5 years ago (2015-12-07 16:54:44 UTC) #39
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/160001
5 years ago (2015-12-07 17:25:45 UTC) #41
Avi (use Gerrit)
https://codereview.chromium.org/1499423004/diff/140001/content/common/gpu/media/android_video_encode_accelerator.h File content/common/gpu/media/android_video_encode_accelerator.h (right): https://codereview.chromium.org/1499423004/diff/140001/content/common/gpu/media/android_video_encode_accelerator.h#newcode59 content/common/gpu/media/android_video_encode_accelerator.h:59: IFRAME_INTERVAL = INT32_MAX, On 2015/12/07 16:43:46, sky wrote: > ...
5 years ago (2015-12-07 17:37:32 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151606)
5 years ago (2015-12-07 19:46:42 UTC) #44
Vitaly Buka (NO REVIEWS)
lgtm
5 years ago (2015-12-07 19:54:35 UTC) #45
Vitaly Buka (NO REVIEWS)
On 2015/12/07 19:54:35, Vitaly Buka wrote: > lgtm for cloud_print
5 years ago (2015-12-07 19:55:43 UTC) #46
asargent_no_longer_on_chrome
apps/ and chrome/browser/extensions/ lgtm
5 years ago (2015-12-07 20:13:45 UTC) #47
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/180001
5 years ago (2015-12-07 20:20:49 UTC) #49
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/145607) win_chromium_x64_rel_ng on ...
5 years ago (2015-12-07 22:45:28 UTC) #51
DaleCurtis
media/ lgtm
5 years ago (2015-12-08 17:59:49 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/180001
5 years ago (2015-12-09 21:12:10 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/90313)
5 years ago (2015-12-09 23:28:05 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499423004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499423004/180001
5 years ago (2015-12-10 15:03:19 UTC) #59
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years ago (2015-12-10 19:41:59 UTC) #60
commit-bot: I haz the power
5 years ago (2015-12-10 19:43:09 UTC) #62
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/d0181f31d10f5126e836fd38bd6bf54d4c4d4872
Cr-Commit-Position: refs/heads/master@{#364429}

Powered by Google App Engine
This is Rietveld 408576698