Remove kuint64max.

Remove kuint64max.

BUG=138542, 488550
Committed: https://crrev.com/bf0746c5b7b8c3eece1a3a66091942efd74f3e4f
Cr-Commit-Position: refs/heads/master@{#364133}

[Avi (use Gerrit), 2015-12-05 01:58:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-05 02:00:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/1

[commit-bot: I haz the power, 2015-12-05 02:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 02:22:41]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-05 19:16:49]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-05 19:17:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/20001

[commit-bot: I haz the power, 2015-12-05 19:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 19:52:44]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Avi (use Gerrit), 2015-12-05 20:21:01]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-05 20:21:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/40001

[commit-bot: I haz the power, 2015-12-05 21:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 21:07:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-06 00:45:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 00:45:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/60001

[commit-bot: I haz the power, 2015-12-06 02:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 02:15:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-06 04:57:50]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 04:58:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/80001

[commit-bot: I haz the power, 2015-12-06 06:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 06:26:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Avi (use Gerrit), 2015-12-06 18:35:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 18:35:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/100001

[commit-bot: I haz the power, 2015-12-06 20:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 20:36:16]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Avi (use Gerrit), 2015-12-06 20:46:18]

avi@chromium.org changed reviewers:
+ dalecurtis@chromium.org, danakj@chromium.org, dcheng@chromium.org,
horo@chromium.org, mark@chromium.org, mmenke@chromium.org, raymes@chromium.org,
sergeyu@chromium.org, sky@chromium.org, thestig@chromium.org

[Avi (use Gerrit), 2015-12-06 20:46:19]

mark: base/
sky: chrome/ and content/
thestig: components/storage_monitor
dalecurtis: media/
mmenke: net/
raymes: ppapi/
sergeyu: remoting/
danakj: storage/
dcheng: third_party/cacheinvalidation/
horo: third_party/WebKit/Source/modules/fetch/

[raymes, 2015-12-06 23:14:48]

ppapi/ rubberstamp lgtm

[horo, 2015-12-07 02:13:20]

third_party/WebKit/Source/modules/fetch/ lgtm

[Mark Mentovai, 2015-12-07 15:05:05]

LGTM in base.

https://codereview.chromium.org/1502503004/diff/100001/base/rand_util.h
File base/rand_util.h (right):

https://codereview.chromium.org/1502503004/diff/100001/base/rand_util.h#newco...
base/rand_util.h:18: BASE_EXPORT uint64_t RandUint64();
Want to whack rand_util_posix/win/nacl/unittest.cc too while you’re changing
these? rand_util.cc was recently fixed in 0a3852a7502c but these other related
files were not.

[Avi (use Gerrit), 2015-12-07 15:50:44]

https://codereview.chromium.org/1502503004/diff/100001/base/rand_util.h
File base/rand_util.h (right):

https://codereview.chromium.org/1502503004/diff/100001/base/rand_util.h#newco...
base/rand_util.h:18: BASE_EXPORT uint64_t RandUint64();
On 2015/12/07 15:05:05, Mark Mentovai wrote:
> Want to whack rand_util_posix/win/nacl/unittest.cc too while you’re changing
> these? rand_util.cc was recently fixed in 0a3852a7502c but these other related
> files were not.

I'll get to those in the grand sweeps, coming soon.

[mmenke, 2015-12-07 16:06:51]

net/ LGTM

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h
File net/base/int128.h (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:53: private:
Suspect this not being indented is what message up indentation below.  Suggest
just fixing it in this CL.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:58: uint64_t hi_;
Should be indented 2 spaces.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:62: uint128(uint16_t);
Should be indented 2 spaces.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128_unitte...
File net/base/int128_unittest.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128_unitte...
net/base/int128_unittest.cc:22: uint128 low_high(0,
std::numeric_limits<uint64_t>::max());
Should probably include stdint.h in this file, too.

https://codereview.chromium.org/1502503004/diff/100001/net/base/upload_file_e...
File net/base/upload_file_element_reader_unittest.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/upload_file_e...
net/base/upload_file_element_reader_unittest.cc:39:
std::numeric_limits<uint64_t>::max(), base::Time()));
include stdint.h

https://codereview.chromium.org/1502503004/diff/100001/net/quic/congestion_co...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/quic/congestion_co...
net/quic/congestion_control/send_algorithm_simulator.cc:72: uint32_t seed =
base::RandInt(0, std::numeric_limits<int32_t>::max());
include stdint.h.

[Avi (use Gerrit), 2015-12-07 16:29:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2015-12-07 16:30:06]

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h
File net/base/int128.h (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:53: private:
On 2015/12/07 16:06:51, mmenke wrote:
> Suspect this not being indented is what message up indentation below.  Suggest
> just fixing it in this CL.

Done.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:58: uint64_t hi_;
On 2015/12/07 16:06:51, mmenke wrote:
> Should be indented 2 spaces.

Done.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128.h#newc...
net/base/int128.h:62: uint128(uint16_t);
On 2015/12/07 16:06:51, mmenke wrote:
> Should be indented 2 spaces.

Done.

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128_unitte...
File net/base/int128_unittest.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/int128_unitte...
net/base/int128_unittest.cc:22: uint128 low_high(0,
std::numeric_limits<uint64_t>::max());
On 2015/12/07 16:06:51, mmenke wrote:
> Should probably include stdint.h in this file, too.

Done.

https://codereview.chromium.org/1502503004/diff/100001/net/base/upload_file_e...
File net/base/upload_file_element_reader_unittest.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/base/upload_file_e...
net/base/upload_file_element_reader_unittest.cc:39:
std::numeric_limits<uint64_t>::max(), base::Time()));
On 2015/12/07 16:06:51, mmenke wrote:
> include stdint.h

Done.

https://codereview.chromium.org/1502503004/diff/100001/net/quic/congestion_co...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/1502503004/diff/100001/net/quic/congestion_co...
net/quic/congestion_control/send_algorithm_simulator.cc:72: uint32_t seed =
base::RandInt(0, std::numeric_limits<int32_t>::max());
On 2015/12/07 16:06:51, mmenke wrote:
> include stdint.h.

Done.

[commit-bot: I haz the power, 2015-12-07 16:30:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/120001

[Lei Zhang, 2015-12-07 16:41:12]

lgtm

[mmenke, 2015-12-07 16:45:10]

https://codereview.chromium.org/1502503004/diff/120001/net/url_request/url_fe...
File net/url_request/url_fetcher_impl.h (right):

https://codereview.chromium.org/1502503004/diff/120001/net/url_request/url_fe...
net/url_request/url_fetcher_impl.h:22: #include "base/compiler_specific.h"
Can remove both the above headers, and replace with base/macros.h  (Compiler
specific isn't related to this change, but is left over from the OVERRIDE one).

[sky, 2015-12-07 16:55:19]

LGTM

[Avi (use Gerrit), 2015-12-07 17:35:16]

https://codereview.chromium.org/1502503004/diff/120001/net/url_request/url_fe...
File net/url_request/url_fetcher_impl.h (right):

https://codereview.chromium.org/1502503004/diff/120001/net/url_request/url_fe...
net/url_request/url_fetcher_impl.h:22: #include "base/compiler_specific.h"
On 2015/12/07 16:45:10, mmenke wrote:
> Can remove both the above headers, and replace with base/macros.h  (Compiler
> specific isn't related to this change, but is left over from the OVERRIDE
one).

Done.

[Avi (use Gerrit), 2015-12-07 17:36:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-07 17:38:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/140001

[danakj, 2015-12-07 18:31:52]

TIL I'm an owner in storage/. LGTM

[commit-bot: I haz the power, 2015-12-07 19:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:57:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Avi (use Gerrit), 2015-12-07 20:18:16]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-07 20:20:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/160001

[dcheng, 2015-12-07 20:24:35]

third_party/cacheinvalidation lgtm

[commit-bot: I haz the power, 2015-12-07 22:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 22:45:30]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[DaleCurtis, 2015-12-08 17:59:03]

media/ lgtm

[Sergey Ulanov, 2015-12-08 18:02:54]

remoting lgtm

[Avi (use Gerrit), 2015-12-09 15:06:50]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-12-09 15:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
raymes@chromium.org, horo@chromium.org, mmenke@chromium.org, sky@chromium.org,
thestig@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1502503004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-09 15:07:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/160001

[commit-bot: I haz the power, 2015-12-09 17:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 17:12:49]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Avi (use Gerrit), 2015-12-09 17:30:49]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-09 17:33:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502503004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502503004/160001

[commit-bot: I haz the power, 2015-12-09 19:53:22]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-12-09 19:54:01]

Description was changed from

==========
Remove kuint64max.

BUG=138542, 488550
==========

to

==========
Remove kuint64max.

BUG=138542, 488550

Committed: https://crrev.com/bf0746c5b7b8c3eece1a3a66091942efd74f3e4f
Cr-Commit-Position: refs/heads/master@{#364133}
==========

[commit-bot: I haz the power, 2015-12-09 19:54:03]

Patchset 9 (id:??) landed as
https://crrev.com/bf0746c5b7b8c3eece1a3a66091942efd74f3e4f
Cr-Commit-Position: refs/heads/master@{#364133}