Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: chrome/browser/extensions/api/messaging/message_service.cc

Issue 1499423004: Remove kint32max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kint9
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/message_service.cc
diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc
index 497bdb0865b3ff6056d90d170bdc1c44e22ffeee..6cde9dc2fc60ee2529c85a3aab5530b075dcc8fd 100644
--- a/chrome/browser/extensions/api/messaging/message_service.cc
+++ b/chrome/browser/extensions/api/messaging/message_service.cc
@@ -4,6 +4,10 @@
#include "chrome/browser/extensions/api/messaging/message_service.h"
+#include <stdint.h>
+
+#include <limits>
+
#include "base/atomic_sequence_num.h"
#include "base/bind.h"
#include "base/callback.h"
@@ -200,8 +204,8 @@ content::RenderProcessHost*
void MessageService::AllocatePortIdPair(int* port1, int* port2) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- unsigned channel_id =
- static_cast<unsigned>(g_next_channel_id.GetNext()) % (kint32max/2);
+ unsigned channel_id = static_cast<unsigned>(g_next_channel_id.GetNext()) %
+ (std::numeric_limits<int32_t>::max() / 2);
unsigned port1_id = channel_id * 2;
unsigned port2_id = channel_id * 2 + 1;

Powered by Google App Engine
This is Rietveld 408576698