OLD | NEW |
---|---|
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "ppapi/shared_impl/id_assignment.h" | 5 #include "ppapi/shared_impl/id_assignment.h" |
6 | 6 |
7 #include "base/basictypes.h" | 7 #include <stdint.h> |
8 | 8 |
9 namespace ppapi { | 9 namespace ppapi { |
10 | 10 |
11 const unsigned int kPPIdTypeBits = 2; | 11 const unsigned int kPPIdTypeBits = 2; |
12 | 12 |
13 const int32 kMaxPPId = kint32max >> kPPIdTypeBits; | 13 const int32_t kMaxPPId = INT32_MAX >> kPPIdTypeBits; |
raymes
2015/12/06 23:16:34
Hmm why not use numeric_limits here?
Avi (use Gerrit)
2015/12/06 23:50:29
Because that's not guaranteed to be constexpr, and
| |
14 | 14 |
15 static_assert(PP_ID_TYPE_COUNT <= (1 << kPPIdTypeBits), | 15 static_assert(PP_ID_TYPE_COUNT <= (1 << kPPIdTypeBits), |
16 "kPPIdTypeBits is too small for all id types"); | 16 "kPPIdTypeBits is too small for all id types"); |
17 | 17 |
18 } // namespace ppapi | 18 } // namespace ppapi |
OLD | NEW |