[proxies] Use JSReceiver::GetKeys() for more purposes

[proxies] Use JSReceiver::GetKeys() for more purposes

Having beefed up GetKeys() to support everything, use it for everything now.

This fixes Object.getOwnPropertyNames and Object.getOwnPropertySymbols for
Proxies, and gets rid of a bunch of code duplication.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/7d1263db477c812d40789c75be2f368e4c0b9769
Cr-Commit-Position: refs/heads/master@{#32620}

[Jakob Kummerow, 2015-12-04 13:39:29]

jkummerow@chromium.org changed reviewers:
+ cbruni@chromium.org, yangguo@chromium.org

[Jakob Kummerow, 2015-12-04 13:39:29]

Feast your eyes on the redness!

Yang, please look at mirrors.js and test-debug.cc.

Camillo, please look at everything else.

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc#oldcode8196
src/objects.cc:8196: // TODO(jkummerow): LayoutTests need adaptation before we
can be spec
Waiting for https://codereview.chromium.org/1503453002/ to land.

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc#newcode8178
src/objects.cc:8178: Handle<JSObject> object, PropertyFilter* filter,
If you have any better ideas than passing |filter| in as a pointer, I'm all
ears. The issue is that when a global proxy has access checks, we have to modify
the filter that's applied when looking at the global object behind it (the
global proxy's hidden prototype).

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc#newcode17853
src/objects.cc:17853: if (accessors->IsPropertyCell()) {
cf. line 17883.

https://codereview.chromium.org/1498593006/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (left):

https://codereview.chromium.org/1498593006/diff/1/test/cctest/test-debug.cc#o...
test/cctest/test-debug.cc:4577: // 1 is PropertyKind.Named;
The Named/Indexed distinction is no longer supported, so we no longer need to
test it.

https://codereview.chromium.org/1498593006/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/1498593006/diff/1/test/cctest/test-debug.cc#n...
test/cctest/test-debug.cc:4615: source = "both_values[0].name() == '1'";
Enumeration order as defined by the spec.

[Yang, 2015-12-04 13:41:41]

debugger part lgtm, assuming that the semantics are correct.

[Camillo Bruni, 2015-12-04 14:37:16]

lgtm

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1498593006/diff/1/src/objects.cc#newcode8178
src/objects.cc:8178: Handle<JSObject> object, PropertyFilter* filter,
On 2015/12/04 at 13:39:29, Jakob wrote:
> If you have any better ideas than passing |filter| in as a pointer, I'm all
ears. The issue is that when a global proxy has access checks, we have to modify
the filter that's applied when looking at the global object behind it (the
global proxy's hidden prototype).

we might want to push all of this onto the KeyAccumulator, but honestly this is
a minor issue :)

[Jakob Kummerow, 2015-12-04 14:58:09]

On 2015/12/04 14:37:16, cbruni wrote:
> we might want to push all of this onto the KeyAccumulator

Good idea; but that's a sizeable refactoring of its own, so I'll postpone that
for now.

[Jakob Kummerow, 2015-12-04 14:58:15]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-12-04 14:58:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498593006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498593006/1

[commit-bot: I haz the power, 2015-12-04 15:20:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 15:21:04]

Description was changed from

==========
[proxies] Use JSReceiver::GetKeys() for more purposes

Having beefed up GetKeys() to support everything, use it for everything now.

This fixes Object.getOwnPropertyNames and Object.getOwnPropertySymbols for
Proxies, and gets rid of a bunch of code duplication.

BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Use JSReceiver::GetKeys() for more purposes

Having beefed up GetKeys() to support everything, use it for everything now.

This fixes Object.getOwnPropertyNames and Object.getOwnPropertySymbols for
Proxies, and gets rid of a bunch of code duplication.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/7d1263db477c812d40789c75be2f368e4c0b9769
Cr-Commit-Position: refs/heads/master@{#32620}
==========

[commit-bot: I haz the power, 2015-12-04 15:21:05]

Patchset 1 (id:??) landed as
https://crrev.com/7d1263db477c812d40789c75be2f368e4c0b9769
Cr-Commit-Position: refs/heads/master@{#32620}