Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: test/cctest/test-api.cc

Issue 1498593006: [proxies] Use JSReceiver::GetKeys() for more purposes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index fa82ae373d074cfed31d96a7834a0ff17a96a61c..abae4512da9e4bcd77ae120388bcb4a303690aa5 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -9850,7 +9850,10 @@ TEST(AccessControlES5) {
CHECK(global1->Set(context1, v8_str("other"), global0).FromJust());
// Regression test for issue 1154.
- CHECK(CompileRun("Object.keys(other).length == 0")
+ CHECK(CompileRun("Object.keys(other).length == 1")
+ ->BooleanValue(context1)
+ .FromJust());
+ CHECK(CompileRun("Object.keys(other)[0] == 'accessible_prop'")
->BooleanValue(context1)
.FromJust());
CHECK(CompileRun("other.blocked_prop").IsEmpty());
@@ -10733,8 +10736,8 @@ THREADED_TEST(Regress91517) {
// Call the runtime version of GetOwnPropertyNames() on the natively
// created object through JavaScript.
CHECK(context->Global()->Set(context.local(), v8_str("obj"), o4).FromJust());
- // PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL = 32
- CompileRun("var names = %GetOwnPropertyNames(obj, 32);");
+ // PROPERTY_FILTER_NONE = 0
+ CompileRun("var names = %GetOwnPropertyKeys(obj, 0);");
ExpectInt32("names.length", 1006);
ExpectTrue("names.indexOf(\"baz\") >= 0");
@@ -10797,8 +10800,8 @@ THREADED_TEST(Regress269562) {
// the natively created object through JavaScript.
CHECK(context->Global()->Set(context.local(), v8_str("obj"), o2).FromJust());
CHECK(context->Global()->Set(context.local(), v8_str("sym"), sym).FromJust());
- // PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL = 32
- CompileRun("var names = %GetOwnPropertyNames(obj, 32);");
+ // PROPERTY_FILTER_NONE = 0
+ CompileRun("var names = %GetOwnPropertyKeys(obj, 0);");
ExpectInt32("names.length", 7);
ExpectTrue("names.indexOf(\"foo\") >= 0");

Powered by Google App Engine
This is Rietveld 408576698