Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1503453002: LayoutTests: fix cross-frame-access-enumeration (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: fix cross-frame-access-enumeration According to the html-cross-origin-objects spec, Object.keys() should return whitelisted ("all-can-read") properties for access-restricted objects. Fix the test to expect this behavior. Also skip it temporarily, because the actual fix will roll in with V8. BUG=chromium:565934 Committed: https://crrev.com/91f34c5d7de95f013d3023ab0a2664e3358710e9 Cr-Commit-Position: refs/heads/master@{#363197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-enumeration.html View 1 chunk +12 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
5 years ago (2015-12-04 13:04:36 UTC) #2
Toon Verwaest
lgtm
5 years ago (2015-12-04 13:10:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503453002/1
5 years ago (2015-12-04 13:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 14:03:53 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-04 14:04:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91f34c5d7de95f013d3023ab0a2664e3358710e9
Cr-Commit-Position: refs/heads/master@{#363197}

Powered by Google App Engine
This is Rietveld 408576698