Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: test/cctest/test-debug.cc

Issue 1498593006: [proxies] Use JSReceiver::GetKeys() for more purposes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index a1aaec8a628ec951b1c64b2fc1d4753279e76921..4dcc091ed09af0b5df32009e4658aae3b996e7d2 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -4574,18 +4574,6 @@ TEST(InterceptorPropertyMirror) {
source = "both_mirror.properties().length";
CHECK_EQ(5, CompileRun(source)->Int32Value(context).FromJust());
- // 1 is PropertyKind.Named;
Jakob Kummerow 2015/12/04 13:39:29 The Named/Indexed distinction is no longer support
- source = "both_mirror.properties(1).length";
- CHECK_EQ(3, CompileRun(source)->Int32Value(context).FromJust());
-
- // 2 is PropertyKind.Indexed;
- source = "both_mirror.properties(2).length";
- CHECK_EQ(2, CompileRun(source)->Int32Value(context).FromJust());
-
- // 3 is PropertyKind.Named | PropertyKind.Indexed;
- source = "both_mirror.properties(3).length";
- CHECK_EQ(5, CompileRun(source)->Int32Value(context).FromJust());
-
// Get the interceptor properties for the object with only named interceptor.
CompileRun("var named_values = named_mirror.properties()");
@@ -4624,19 +4612,19 @@ TEST(InterceptorPropertyMirror) {
}
// Check the property names.
- source = "both_values[0].name() == 'a'";
+ source = "both_values[0].name() == '1'";
Jakob Kummerow 2015/12/04 13:39:29 Enumeration order as defined by the spec.
CHECK(CompileRun(source)->BooleanValue(context).FromJust());
- source = "both_values[1].name() == 'b'";
+ source = "both_values[1].name() == '10'";
CHECK(CompileRun(source)->BooleanValue(context).FromJust());
- source = "both_values[2].name() == 'c'";
+ source = "both_values[2].name() == 'a'";
CHECK(CompileRun(source)->BooleanValue(context).FromJust());
- source = "both_values[3].name() == 1";
+ source = "both_values[3].name() == 'b'";
CHECK(CompileRun(source)->BooleanValue(context).FromJust());
- source = "both_values[4].name() == 10";
+ source = "both_values[4].name() == 'c'";
CHECK(CompileRun(source)->BooleanValue(context).FromJust());
}

Powered by Google App Engine
This is Rietveld 408576698