Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498593003: GN(android): Distinguish java_binary from java_library in build_config (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@build_config_barriers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android): Distinguish java_binary from java_library in build_config BUG=565359 Committed: https://crrev.com/b1d457698f37d3299af8219803691159a8f4b877 Cr-Commit-Position: refs/heads/master@{#363141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M build/android/gyp/write_build_config.py View 5 chunks +6 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 4 chunks +13 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1493803003 Patch 1

Dependent Patchsets:

Issue 1492963004 Patch 1

Messages

Total messages: 10 (5 generated)
agrieve
On 2015/12/03 16:08:26, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ☻
5 years ago (2015-12-03 16:08:35 UTC) #3
pkotwicz
LGTM \o/
5 years ago (2015-12-03 20:32:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498593003/1
5 years ago (2015-12-04 04:05:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 05:34:09 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-04 05:35:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b1d457698f37d3299af8219803691159a8f4b877
Cr-Commit-Position: refs/heads/master@{#363141}

Powered by Google App Engine
This is Rietveld 408576698