Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1492963004: GN: asset_location -> android_assets() for mandoline_apk (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@build_config_java_binary
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: asset_location -> android_assets() for mandoline_apk Also deletes generate_mojo_shell_assets_list.gni, as it's no longer used. TESTED=Verified that unzip -lv of Mandoline.apk before / after looks the same BUG=547162 Committed: https://crrev.com/d9349ab5d4efff9e01e6ec3377662f16fdf59f1c Cr-Commit-Position: refs/heads/master@{#363227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -124 lines) Patch
M components/html_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 3 chunks +12 lines, -42 lines 0 comments Download
D mojo/generate_mojo_shell_assets_list.gni View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/runner/BUILD.gn View 3 chunks +12 lines, -9 lines 0 comments Download
M mojo/runner/host/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/tools/generate_mojo_shell_assets_list.py View 1 chunk +0 lines, -46 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
sky - please review note: considered deleting generate_mojo_shell_assets_list.py in a separate commit, but figured that ...
5 years ago (2015-12-03 03:54:35 UTC) #3
sky
LGTM
5 years ago (2015-12-03 16:55:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492963004/1
5 years ago (2015-12-04 15:25:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 16:41:01 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-04 16:41:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9349ab5d4efff9e01e6ec3377662f16fdf59f1c
Cr-Commit-Position: refs/heads/master@{#363227}

Powered by Google App Engine
This is Rietveld 408576698