GN(android): Enhance dependency logic in .build_config files

GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359
Committed: https://crrev.com/a05756beec16fa870314b4384bbcc0c90c209801
Cr-Commit-Position: refs/heads/master@{#363068}

[agrieve, 2015-12-03 16:07:52]

Description was changed from

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=TODO
==========

to

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359
==========

[agrieve, 2015-12-03 16:07:52]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2015-12-03 16:08:16]

On 2015/12/03 16:07:52, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

☺

[pkotwicz, 2015-12-03 20:13:08]

lgtm

https://codereview.chromium.org/1493803003/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1493803003/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:293: if (options.type == 'java_library'
and not options.bypass_platform_checks):
Why did you add the brackets?

[agrieve, 2015-12-03 20:22:19]

https://codereview.chromium.org/1493803003/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1493803003/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:293: if (options.type == 'java_library'
and not options.bypass_platform_checks):
On 2015/12/03 20:13:08, pkotwicz wrote:
> Why did you add the brackets?

Whoops, that's an artifact of me splitting up this change into 2 CLs
after-the-fact. In the next CL it wraps to the next line.

[agrieve, 2015-12-03 20:22:21]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-12-03 20:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493803003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493803003/1

[commit-bot: I haz the power, 2015-12-03 21:40:17]

Description was changed from

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359
==========

to

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359
==========

[commit-bot: I haz the power, 2015-12-03 21:40:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 21:41:31]

Description was changed from

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359
==========

to

==========
GN(android): Enhance dependency logic in .build_config files

* Don't let java_library pass through android_assets / android_resources
* Don't let android_apk / deps_dex / resource_rewriter be used as deps

BUG=565359

Committed: https://crrev.com/a05756beec16fa870314b4384bbcc0c90c209801
Cr-Commit-Position: refs/heads/master@{#363068}
==========

[commit-bot: I haz the power, 2015-12-03 21:41:32]

Patchset 1 (id:??) landed as
https://crrev.com/a05756beec16fa870314b4384bbcc0c90c209801
Cr-Commit-Position: refs/heads/master@{#363068}