Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: build/config/android/rules.gni

Issue 1498593003: GN(android): Distinguish java_binary from java_library in build_config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@build_config_barriers
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index a1da43ab5aa138e4f34b3950b71af68f9ef40d04..5887a547d569f1a5493acd5146adcce86f6b92cd 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -889,12 +889,11 @@ template("java_strings_grd_prebuilt") {
template("java_binary") {
set_sources_assignment_filter([])
- # TODO(cjhopman): This should not act like a java_library for dependents (i.e.
- # dependents shouldn't get the jar in their classpath, etc.).
java_library_impl(target_name) {
forward_variables_from(invoker, "*")
supports_android = false
main_class = invoker.main_class
+ is_java_binary = true
}
}
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698