Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149683005: about:omnibox - add current page classification to possible settings (Closed)

Created:
6 years, 10 months ago by Mark P
Modified:
6 years, 10 months ago
CC:
chromium-reviews, James Su, Ilya Sherman, arv+watch_chromium.org, asvitkine+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

about:omnibox - add current page classification to possible settings It's a bit ugly--I wish I could get the text and the dropdown indented a bit (the width of one checkbox) so it lines up with the other text. But it's not a big deal and not worth my time figuring out. BUG=265675 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247854

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M chrome/browser/resources/omnibox/omnibox.html View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/common/metrics/proto/omnibox_event.proto View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Mark P
Evan, could you please take a look at this change? No hurry. Alexei, can you ...
6 years, 10 months ago (2014-01-29 21:44:08 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/149683005/diff/1/chrome/common/metrics/proto/omnibox_event.proto File chrome/common/metrics/proto/omnibox_event.proto (right): https://codereview.chromium.org/149683005/diff/1/chrome/common/metrics/proto/omnibox_event.proto#newcode114 chrome/common/metrics/proto/omnibox_event.proto:114: // so that these new options are displayed on ...
6 years, 10 months ago (2014-01-29 21:48:03 UTC) #2
Mark P
https://codereview.chromium.org/149683005/diff/1/chrome/common/metrics/proto/omnibox_event.proto File chrome/common/metrics/proto/omnibox_event.proto (right): https://codereview.chromium.org/149683005/diff/1/chrome/common/metrics/proto/omnibox_event.proto#newcode114 chrome/common/metrics/proto/omnibox_event.proto:114: // so that these new options are displayed on ...
6 years, 10 months ago (2014-01-29 22:23:31 UTC) #3
Alexei Svitkine (slow)
proto lgtm, I didn't look at the rest
6 years, 10 months ago (2014-01-29 22:29:14 UTC) #4
Evan Stade
lgtm
6 years, 10 months ago (2014-01-29 22:36:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/149683005/1
6 years, 10 months ago (2014-01-29 22:44:41 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/149683005/1
6 years, 10 months ago (2014-01-30 03:14:29 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:29:37 UTC) #9
Message was sent while issue was closed. 
Change committed as 247854

Powered by Google App Engine
This is Rietveld 408576698