Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 149683005: about:omnibox - add current page classification to possible settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS = 7; 101 INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS = 7;
102 102
103 // The new tab page in which this omnibox interaction first started 103 // The new tab page in which this omnibox interaction first started
104 // with the user having focus in the fakebox. 104 // with the user having focus in the fakebox.
105 INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS = 8; 105 INSTANT_NTP_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;
106 106
107 // The user is on a search result page that's not doing search term 107 // The user is on a search result page that's not doing search term
108 // replacement, meaning the URL of the page should've appeared in the 108 // replacement, meaning the URL of the page should've appeared in the
109 // omnibox before the user started editing it, not the search terms. 109 // omnibox before the user started editing it, not the search terms.
110 SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9; 110 SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9;
111
112 // When adding new classifications, please consider adding them in
113 // chrome/browser/resources/omnibox/omnibox.html
114 // so that these new options are displayed on about:omnibox.
Alexei Svitkine (slow) 2014/01/29 21:48:04 Can you send a CL to update this proto on the serv
Mark P 2014/01/29 22:23:32 Done.
111 } 115 }
112 optional PageClassification current_page_classification = 10; 116 optional PageClassification current_page_classification = 10;
113 117
114 // What kind of input the user provided. 118 // What kind of input the user provided.
115 enum InputType { 119 enum InputType {
116 INVALID = 0; // Empty input (should not reach here) 120 INVALID = 0; // Empty input (should not reach here)
117 UNKNOWN = 1; // Valid input whose type cannot be determined 121 UNKNOWN = 1; // Valid input whose type cannot be determined
118 REQUESTED_URL = 2; // DEPRECATED. Input autodetected as UNKNOWN, which the 122 REQUESTED_URL = 2; // DEPRECATED. Input autodetected as UNKNOWN, which the
119 // user wants to treat as an URL by specifying a 123 // user wants to treat as an URL by specifying a
120 // desired_tld 124 // desired_tld
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 // See AutocompleteController::ResetSession() for more details on the 235 // See AutocompleteController::ResetSession() for more details on the
232 // definition of a session. 236 // definition of a session.
233 // See chrome/browser/autocomplete/search_provider.cc for a specific usage 237 // See chrome/browser/autocomplete/search_provider.cc for a specific usage
234 // example. 238 // example.
235 repeated fixed32 field_trial_triggered_in_session = 4; 239 repeated fixed32 field_trial_triggered_in_session = 4;
236 } 240 }
237 // A list of diagnostic information about each provider. Providers 241 // A list of diagnostic information about each provider. Providers
238 // will appear at most once in this list. 242 // will appear at most once in this list.
239 repeated ProviderInfo provider_info = 12; 243 repeated ProviderInfo provider_info = 12;
240 } 244 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698