chrome/common/metrics/proto/omnibox_event.proto - Issue 149683005: about:omnibox - add current page classification to possible settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 149683005: about:omnibox - add current page classification to possible settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/metrics/proto/omnibox_event.proto

diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto

index 0896c4a908d37df6fc68a60042ee090ae5d12039..cc2ca0404f7ca674561ddc90a7895055127c1dbc 100644

--- a/chrome/common/metrics/proto/omnibox_event.proto

+++ b/chrome/common/metrics/proto/omnibox_event.proto

@@ -108,6 +108,10 @@ message OmniboxEventProto {

// replacement, meaning the URL of the page should've appeared in the

// omnibox before the user started editing it, not the search terms.

SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9;

+ // When adding new classifications, please consider adding them in

+ // chrome/browser/resources/omnibox/omnibox.html

+ // so that these new options are displayed on about:omnibox.

Alexei Svitkine (slow) 2014/01/29 21:48:04 Can you send a CL to update this proto on the serv

Mark P 2014/01/29 22:23:32 Done.

}

optional PageClassification current_page_classification = 10;

« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc ('k') | no next file » | no next file with comments »