Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc

Issue 149683005: about:omnibox - add current page classification to possible settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
diff --git a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
index 33c324a89b100784b2f47fa2c1e13acab267bf6b..5a84bd7845d31e8d9d3ad057ffb1795859ad8958 100644
--- a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
+++ b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
@@ -173,7 +173,7 @@ bool OmniboxUIHandler::LookupIsTypedHost(const base::string16& host,
}
void OmniboxUIHandler::StartOmniboxQuery(const base::ListValue* input) {
- DCHECK_EQ(4u, input->GetSize());
+ DCHECK_EQ(5u, input->GetSize());
base::string16 input_string;
bool return_val = input->GetString(0, &input_string);
DCHECK(return_val);
@@ -186,6 +186,9 @@ void OmniboxUIHandler::StartOmniboxQuery(const base::ListValue* input) {
bool prefer_keyword;
return_val = input->GetBoolean(3, &prefer_keyword);
DCHECK(return_val);
+ int current_page_classification;
+ return_val = input->GetInteger(4, &current_page_classification);
+ DCHECK(return_val);
// Reset the controller. If we don't do this, then the
// AutocompleteController might inappropriately set its |minimal_changes|
// variable (or something else) and some providers will short-circuit
@@ -198,7 +201,8 @@ void OmniboxUIHandler::StartOmniboxQuery(const base::ListValue* input) {
cursor_position,
base::string16(), // user's desired tld (top-level domain)
GURL(),
- AutocompleteInput::INVALID_SPEC,
+ static_cast<AutocompleteInput::PageClassification>(
+ current_page_classification),
prevent_inline_autocomplete,
prefer_keyword,
true, // allow exact keyword matches

Powered by Google App Engine
This is Rietveld 408576698