Issue 149662: Fix DOA problem with dev channel. If there is no...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149662: Fix DOA problem with dev channel. If there is no... (Closed)

Created:
11 years, 5 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, ---DO NOT USE---rsesek

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix DOA problem with dev channel. If there is no ~/Library/Preferences/com.google.Chrome.plist, we do a 1st run dialog. This dialog spins a run loop and messes up MessageLoop. "Choke brutally" means, among other things, "never process IPC messages to/from render". Reference CLs: http://codereview.chromium.org/149082 http://codereview.chromium.org/149029 http://codereview.chromium.org/146006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20712

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	base/message_pump_mac.mm	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

11 years, 5 months ago (2009-07-15 02:50:50 UTC) #3

Ew, gross, but this actually seems like the right fix.  LGTM.  We should
actually put the same sort of thing in a couple of other spots.