Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2101)

Unified Diff: base/message_pump_mac.mm

Issue 149662: Fix DOA problem with dev channel. If there is no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_mac.mm
===================================================================
--- base/message_pump_mac.mm (revision 20638)
+++ base/message_pump_mac.mm (working copy)
@@ -184,6 +184,15 @@
if (!delegate_) {
// This point can be reached with a NULL delegate_ if Run is not on the
// stack but foreign code is spinning the CFRunLoop.
+
+ // TODO(???): we get here while looping in our temporary 1st run
+ // dialog. If we simply return false, we choke rather brutally
+ // (we no longer do work ever again). For now, we simply
+ // re-signal ourself so we come around again. The problem only
+ // happens in a branded build if
+ // ~/Library/Preferences/com.google.Chrome.plist does not exist.
+ CFRunLoopSourceSignal(work_source_);
+
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698