Issue 149082: Handle message pump sources firing without delegates available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149082: Handle message pump sources firing without delegates available (Closed)

Created:
11 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Gracefully do nothing when run loop sources fire and no delegate is available. This can happen if foreign code spins the run loop without Run being on the stack. BUG=2708 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19382

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	base/message_pump_mac.mm	View		4 chunks	+26 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

darin (slow to review)

11 years, 6 months ago (2009-06-26 17:33:02 UTC) #2

Ah, yes... I remember fixing this same bug for Windows.

LGTM