Issue 146006: Fire off work in outer run loops when inner loops exit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146006: Fire off work in outer run loops when inner loops exit (Closed)

Created:
11 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Allow work that was deferred on account of not being runnable in a nested loop to be processed when returning to an outer loop. BUG=11470 13442 13468 TEST=base_unittests, test cases in bugs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19272

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+277 lines, -133 lines)			Patch
M	base/message_loop_unittest.cc	View	6 7	6 chunks	+54 lines, -16 lines	0 comments	Download
M	base/message_pump_mac.h	View	1 2 3	3 chunks	+50 lines, -23 lines	0 comments	Download
M	base/message_pump_mac.mm	View	1 2 3 4	5 chunks	+173 lines, -94 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

This looks good, but where are the unit tests? :-)

11 years, 6 months ago (2009-06-23 21:10:43 UTC) #3

Mark Mentovai

I added a test that should simulate the run loop conditions that we were seeing. ...

11 years, 6 months ago (2009-06-23 22:42:46 UTC) #4

LGTM

Expand Messages | Collapse Messages