Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1495043002: Stop requiring NotificationAction action and title to be non-empty (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Stop requiring NotificationAction action and title to be non-empty Improve spec compliance. Note that http/tests/notifications/serviceworkerregistration-document-actions-throw.html still tests that they are set (but it's no longer possible to have an equivalent check in NotificationDataTest, since required WebIDL attributes are enforced at the V8 level by [1], and are bypassed when creating IDL objects from C++). [1]: https://chromium.googlesource.com/chromium/src/+/dfd8ec1b3edb7f876235bec1138ecec4f2da748d/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp#55 BUG=557624 Review URL: https://codereview.chromium.org/1487063002 Cr-Commit-Position: refs/heads/master@{#362469} (cherry picked from commit 56c5368ca167742af3dfdd0bf8f879984b2ad05b) Committed: https://chromium.googlesource.com/chromium/src/+/35bd3cd019fa030cad7500cd0d4c47d93d24333e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -82 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
5 years ago (2015-12-03 17:15:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35bd3cd019fa030cad7500cd0d4c47d93d24333e.

Powered by Google App Engine
This is Rietveld 408576698