Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop requiring NotificationAction action and title to be non-empty Improve spec compliance. Note that http/tests/notifications/serviceworkerregistration-document-actions-throw.html still tests that they are set (but it's no longer possible to have an equivalent check in NotificationDataTest, since required WebIDL attributes are enforced at the V8 level by [1], and are bypassed when creating IDL objects from C++). [1]: https://chromium.googlesource.com/chromium/src/+/dfd8ec1b3edb7f876235bec1138ecec4f2da748d/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp#55 BUG=557624 Committed: https://crrev.com/56c5368ca167742af3dfdd0bf8f879984b2ad05b Cr-Commit-Position: refs/heads/master@{#362469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -82 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487063002/1
5 years ago (2015-12-01 17:28:18 UTC) #2
johnme
5 years ago (2015-12-01 17:36:46 UTC) #4
Peter Beverloo
lgtm, thank you!
5 years ago (2015-12-01 17:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487063002/1
5 years ago (2015-12-01 17:40:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 19:18:42 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-01 19:19:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c5368ca167742af3dfdd0bf8f879984b2ad05b
Cr-Commit-Position: refs/heads/master@{#362469}

Powered by Google App Engine
This is Rietveld 408576698