Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

Issue 1495043002: Stop requiring NotificationAction action and title to be non-empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
index 39b1916cb1e864b9bcfd8d69710d99ab68b2cdf2..50ae0d379e33d81f0954232569f20fdfd2d52b01 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
@@ -179,43 +179,6 @@ TEST_F(NotificationDataTest, DirectionValues)
}
}
-TEST_F(NotificationDataTest, RequiredActionProperties)
-{
- NotificationOptions options;
-
- // The NotificationAction.action property is required.
- {
- NotificationAction action;
- action.setTitle(kNotificationActionTitle);
-
- HeapVector<NotificationAction> actions;
- actions.append(action);
-
- options.setActions(actions);
-
- TrackExceptionState exceptionState;
- WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
- ASSERT_TRUE(exceptionState.hadException());
- EXPECT_EQ("NotificationAction `action` must not be empty.", exceptionState.message());
- }
-
- // The NotificationAction.title property is required.
- {
- NotificationAction action;
- action.setAction(kNotificationActionAction);
-
- HeapVector<NotificationAction> actions;
- actions.append(action);
-
- options.setActions(actions);
-
- TrackExceptionState exceptionState;
- WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
- ASSERT_TRUE(exceptionState.hadException());
- EXPECT_EQ("NotificationAction `title` must not be empty.", exceptionState.message());
- }
-}
-
TEST_F(NotificationDataTest, MaximumActionCount)
{
HeapVector<NotificationAction> actions;
« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698