Stop requiring NotificationAction action and title to be non-empty

third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/notifications/NotificationData.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/modules/v8/UnionTypesModules.h"
 #include "core/testing/NullExecutionContext.h"
@@ skipping 161 matching lines @@
         options.setDir(direction);
 
         TrackExceptionState exceptionState;
         WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
         ASSERT_FALSE(exceptionState.hadException());
 
         EXPECT_EQ(mappings.get(direction), notificationData.direction);
     }
 }
 
-TEST_F(NotificationDataTest, RequiredActionProperties)
-{
-    NotificationOptions options;
-
-    // The NotificationAction.action property is required.
-    {
-        NotificationAction action;
-        action.setTitle(kNotificationActionTitle);
-
-        HeapVector<NotificationAction> actions;
-        actions.append(action);
-
-        options.setActions(actions);
-
-        TrackExceptionState exceptionState;
-        WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
-        ASSERT_TRUE(exceptionState.hadException());
-        EXPECT_EQ("NotificationAction `action` must not be empty.", exceptionState.message());
-    }
-
-    // The NotificationAction.title property is required.
-    {
-        NotificationAction action;
-        action.setAction(kNotificationActionAction);
-
-        HeapVector<NotificationAction> actions;
-        actions.append(action);
-
-        options.setActions(actions);
-
-        TrackExceptionState exceptionState;
-        WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
-        ASSERT_TRUE(exceptionState.hadException());
-        EXPECT_EQ("NotificationAction `title` must not be empty.", exceptionState.message());
-    }
-}
-
 TEST_F(NotificationDataTest, MaximumActionCount)
 {
     HeapVector<NotificationAction> actions;
     for (size_t i = 0; i < Notification::maxActions() + 2; ++i) {
         NotificationAction action;
         action.setAction(String::number(i));
         action.setTitle(kNotificationActionTitle);
 
         actions.append(action);
     }
 
     NotificationOptions options;
     options.setActions(actions);
 
     TrackExceptionState exceptionState;
     WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
     ASSERT_FALSE(exceptionState.hadException());
 
     // The stored actions will be capped to |maxActions| entries.
     ASSERT_EQ(Notification::maxActions(), notificationData.actions.size());
 
     for (size_t i = 0; i < Notification::maxActions(); ++i) {
         WebString expectedAction = String::number(i);
         EXPECT_EQ(expectedAction, notificationData.actions[i].action);
     }
 }
 
 } // namespace
 } // namespace blink