native_client_sdk/src/build_tools/buildbot_run.py - Issue 1493443002: Revert of [NaCl SDK] Remove support for bionic toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/buildbot_run.py

Issue 1493443002: Revert of [NaCl SDK] Remove support for bionic toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/build_tools/buildbot_common.py ('k') | native_client_sdk/src/build_tools/json/naclsdk_manifest2.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/build_tools/buildbot_run.py

diff --git a/native_client_sdk/src/build_tools/buildbot_run.py b/native_client_sdk/src/build_tools/buildbot_run.py

index f6e4ee79d2137fb8739e88fd713ca010693195fe..5971a58c1647c36a2a851a979d4b0ba0bee38fc5 100755

--- a/native_client_sdk/src/build_tools/buildbot_run.py

+++ b/native_client_sdk/src/build_tools/buildbot_run.py

@@ -63,6 +63,8 @@

new_script_dir = SCRIPT_DIR

args = [sys.executable, 'build_sdk.py']

+ if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):

+ args.append('--bionic')

try:

Run(args, cwd=new_script_dir)

@@ -85,6 +87,11 @@

])

cmd.extend([sys.executable, 'test_sdk.py'])

+ # TODO(noelallen): crbug 386332

+ # For Bionic SDK, only build do a build test until we have hardware.

+ if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):

+ cmd.extend(['build_examples', 'copy_tests', 'build_tests'])

Run(cmd, cwd=SCRIPT_DIR)