Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: android_webview/native/aw_http_auth_handler.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_http_auth_handler.cc
diff --git a/android_webview/native/aw_http_auth_handler.cc b/android_webview/native/aw_http_auth_handler.cc
index 700270a78a4a73f40a32978be9274ca6d70871a0..8f4293b8f48dc68156b4d8ccb525d402ade3a06e 100644
--- a/android_webview/native/aw_http_auth_handler.cc
+++ b/android_webview/native/aw_http_auth_handler.cc
@@ -38,9 +38,9 @@ AwHttpAuthHandler:: ~AwHttpAuthHandler() {
}
void AwHttpAuthHandler::Proceed(JNIEnv* env,
- jobject obj,
- jstring user,
- jstring password) {
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& user,
+ const JavaParamRef<jstring>& password) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (login_delegate_.get()) {
login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user),
@@ -49,7 +49,7 @@ void AwHttpAuthHandler::Proceed(JNIEnv* env,
}
}
-void AwHttpAuthHandler::Cancel(JNIEnv* env, jobject obj) {
+void AwHttpAuthHandler::Cancel(JNIEnv* env, const JavaParamRef<jobject>& obj) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (login_delegate_.get()) {
login_delegate_->Cancel();
« no previous file with comments | « android_webview/native/aw_http_auth_handler.h ('k') | android_webview/native/aw_message_port_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698