Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: android_webview/native/aw_message_port_service_impl.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_message_port_service_impl.h
diff --git a/android_webview/native/aw_message_port_service_impl.h b/android_webview/native/aw_message_port_service_impl.h
index 7f42421bae70957862875b05cf9b7f5083865e10..2ee31b46c0492a2e69e4c43cc364cd64a7a10c47 100644
--- a/android_webview/native/aw_message_port_service_impl.h
+++ b/android_webview/native/aw_message_port_service_impl.h
@@ -42,10 +42,18 @@ class AwMessagePortServiceImpl : public AwMessagePortService {
void CleanupPort(int message_port_id) override;
// Methods called from Java.
- void PostAppToWebMessage(JNIEnv* env, jobject object, int sender_id,
- jstring message, jintArray sent_ports);
- void ClosePort(JNIEnv* env, jobject object, int message_port_id);
- void ReleaseMessages(JNIEnv* env, jobject object, int message_port_id);
+ void PostAppToWebMessage(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& object,
+ int sender_id,
+ const base::android::JavaParamRef<jstring>& message,
+ const base::android::JavaParamRef<jintArray>& sent_ports);
+ void ClosePort(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& object,
+ int message_port_id);
+ void ReleaseMessages(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& object,
+ int message_port_id);
void RemoveSentPorts(const std::vector<int>& sent_ports);
« no previous file with comments | « android_webview/native/aw_http_auth_handler.cc ('k') | android_webview/native/aw_message_port_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698